Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71f26147 authored by Hai Zhang's avatar Hai Zhang
Browse files

Revert "Add special apps access settings page for financial app."

This reverts commit 43374eab.

Reason for revert: No longer needed because we are using whitelist for
SMS permission

Fixes: 135213238
Test: presubmit
Change-Id: I182be4a1136521f325866e70e875439c17816ef2
parent ab63fd3c
Loading
Loading
Loading
Loading
+0 −6
Original line number Diff line number Diff line
@@ -7359,8 +7359,6 @@
    <string name="keywords_android_version">android security patch level, baseband version, kernel version</string>
    <!-- Search keywords for dark mode settings [CHAR LIMIT=NONE] -->
    <string name="keywords_dark_ui_mode">theme, light, dark, mode</string>
    <!-- Search keywords for financial apps sms access settings [CHAR LIMIT=NONE] -->
    <string name="keywords_financial_apps_sms_access">financial app, sms, permission</string>
    <!-- Search keyword for Device Theme Settings [CHAR LIMIT=NONE] -->
    <string name="keywords_systemui_theme">dark theme</string>
@@ -9408,10 +9406,6 @@
    <!-- Summary of number of apps currently can write system settings [CHAR LIMIT=60] -->
    <string name="write_settings_summary"><xliff:g id="count" example="10">%1$d</xliff:g> of <xliff:g id="count" example="10">%2$d</xliff:g> apps allowed to modify system settings</string>
    <!-- Settings title in main settings screen for financial apps sms access [CHAR LIMIT=60] -->
    <string name="financial_apps_sms_access_title">Financial Apps Sms Access</string>
    <!-- Preference key for financial apps sms access screen -->
    <string name="financial_sms_root_screen_key" translatable="false">financial_sms_root_screen_key</string>
    <!-- Label for showing apps that can install other apps [CHAR LIMIT=45] -->
    <string name="filter_install_sources_apps">Can install other apps</string>
    <!-- Label for showing apps that can write system settings [CHAR LIMIT=45] -->
+0 −22
Original line number Diff line number Diff line
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (C) 2018 The Android Open Source Project

     Licensed under the Apache License, Version 2.0 (the "License");
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at

          http://www.apache.org/licenses/LICENSE-2.0

     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and
     limitations under the License.
-->
<PreferenceScreen
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:settings="http://schemas.android.com/apk/res-auto"
    android:key="@string/financial_sms_root_screen_key"
    android:title="@string/financial_apps_sms_access_title"
    settings:controller="com.android.settings.applications.specialaccess.financialapps.FinancialAppsController" />
+0 −6
Original line number Diff line number Diff line
@@ -145,12 +145,6 @@
            android:value="com.android.settings.Settings$ChangeWifiStateActivity" />
    </Preference>

    <Preference
        android:key="financial_apps_sms_access"
        android:title="@string/financial_apps_sms_access_title"
        android:fragment="com.android.settings.applications.specialaccess.financialapps.FinancialAppsSmsAccess"
        settings:keywords="@string/keywords_financial_apps_sms_access" />

    <Preference
        android:key="special_access_more"
        android:title="@string/special_access_more"
+0 −156
Original line number Diff line number Diff line
/*
 * Copyright (C) 2018 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.android.settings.applications.specialaccess.financialapps;

import static android.Manifest.permission.READ_SMS;
import static android.Manifest.permission.SMS_FINANCIAL_TRANSACTIONS;

import android.app.AppOpsManager;
import android.content.Context;
import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import android.content.pm.PackageManager.NameNotFoundException;
import android.os.Build;
import android.util.Log;

import androidx.preference.Preference;
import androidx.preference.PreferenceScreen;
import androidx.preference.SwitchPreference;

import com.android.internal.annotations.VisibleForTesting;
import com.android.internal.util.ArrayUtils;
import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.applications.ApplicationsState;
import com.android.settingslib.applications.ApplicationsState.AppEntry;

import java.util.ArrayList;
import java.util.List;

public class FinancialAppsController extends BasePreferenceController
        implements ApplicationsState.Callbacks {
    private final static String TAG = FinancialAppsController.class.getSimpleName();

    @VisibleForTesting
    PreferenceScreen mRoot;

    public FinancialAppsController(Context context, String key) {
        super(context, key);
    }

    @AvailabilityStatus
    public int getAvailabilityStatus() {
        return AVAILABLE;
    }

    @Override
    public void displayPreference(PreferenceScreen screen) {
        super.displayPreference(screen);
        mRoot = screen;
    }

    @Override
    public void updateState(Preference preference) {
        updateList();
    }

    private void updateList() {
        mRoot.removeAll();

        final PackageManager packageManager = mContext.getPackageManager();
        final AppOpsManager appOpsManager = mContext.getSystemService(AppOpsManager.class);

        final List<PackageInfo> installedPackages =
                packageManager.getInstalledPackages(PackageManager.GET_PERMISSIONS);
        final int numPackages = installedPackages.size();
        for (int i = 0; i < numPackages; i++) {
            final PackageInfo installedPackage = installedPackages.get(i);

            if (installedPackage.requestedPermissions == null) {
                continue;
            }
            final int targetSdk = installedPackage.applicationInfo.targetSdkVersion;
            final String pkgName = installedPackage.packageName;

            if ((targetSdk >= Build.VERSION_CODES.Q
                    && ArrayUtils.contains(installedPackage.requestedPermissions,
                            SMS_FINANCIAL_TRANSACTIONS))
                    || (targetSdk < Build.VERSION_CODES.Q
                    && ArrayUtils.contains(installedPackage.requestedPermissions,
                            READ_SMS))) {
                final SwitchPreference pref = new SwitchPreference(mRoot.getContext());
                pref.setTitle(installedPackage.applicationInfo.loadLabel(packageManager));
                pref.setKey(pkgName);

                pref.setChecked(
                        appOpsManager.checkOp(
                                targetSdk >= Build.VERSION_CODES.Q
                                        ? AppOpsManager.OP_SMS_FINANCIAL_TRANSACTIONS
                                        : AppOpsManager.OP_READ_SMS,
                                installedPackage.applicationInfo.uid,
                                pkgName) == AppOpsManager.MODE_ALLOWED);

                pref.setOnPreferenceChangeListener((preference, newValue) -> {
                    final int uid;
                    try {
                        uid = packageManager.getPackageInfo(preference.getKey(), 0)
                                .applicationInfo.uid;
                    } catch (NameNotFoundException e) {
                        Log.e(TAG, "onPreferenceChange: Failed to get uid for "
                                + preference.getKey());
                        return false;
                    }

                    appOpsManager.setMode(
                            targetSdk >= Build.VERSION_CODES.Q
                                    ? AppOpsManager.OP_SMS_FINANCIAL_TRANSACTIONS
                                    : AppOpsManager.OP_READ_SMS,
                            uid,
                            pkgName,
                            (Boolean) newValue ? AppOpsManager.MODE_ALLOWED
                                    : AppOpsManager.MODE_IGNORED);
                    return true;
                });
                mRoot.addPreference(pref);
            }
        }
    }

    @Override
    public void onRunningStateChanged(boolean running) {}

    @Override
    public void onPackageListChanged() {
        updateList();
    }

    @Override
    public void onRebuildComplete(ArrayList<AppEntry> apps) {}

    @Override
    public void onPackageIconChanged() {}

    @Override
    public void onPackageSizeChanged(String packageName) {}

    @Override
    public void onAllSizesComputed() {}

    @Override
    public void onLauncherInfoChanged() {}

    @Override
    public void onLoadEntriesCompleted() {}
}
+0 −64
Original line number Diff line number Diff line
/*
 * Copyright (C) 2018 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.settings.applications.specialaccess.financialapps;

import android.app.settings.SettingsEnums;
import android.content.Context;
import android.provider.SearchIndexableResource;

import com.android.settings.R;
import com.android.settings.dashboard.DashboardFragment;
import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.search.Indexable;
import com.android.settingslib.search.SearchIndexable;

import java.util.ArrayList;
import java.util.List;

@SearchIndexable
public class FinancialAppsSmsAccess extends DashboardFragment {
    private final static String TAG = FinancialAppsSmsAccess.class.getSimpleName();

    @Override
    protected String getLogTag() {
        return TAG;
    }

    @Override
    protected int getPreferenceScreenResId() {
        return R.xml.financial_app_sms_access;
    }

    @Override
    public int getMetricsCategory() {
      return SettingsEnums.SETTINGS_FINANCIAL_APPS_SMS_ACCESS;
    }

    public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
            new BaseSearchIndexProvider() {
                @Override
                public List<SearchIndexableResource> getXmlResourcesToIndex(Context context,
                        boolean enabled) {
                    final ArrayList<SearchIndexableResource> result = new ArrayList<>();

                    final SearchIndexableResource sir = new SearchIndexableResource(context);
                    sir.xmlResId = R.xml.financial_app_sms_access;
                    result.add(sir);
                    return result;
                }
            };
}
Loading