Commit 6e4e8913 authored Dec 04, 2017 by Bruno Martins

Settings: appops: Privacy Guard for P (2/2)



This had been partially split into CMParts, now LineageParts.
The AppOps functionality still lives here.

Squash of the following changes, adapted to the Lineage SDK:

    Author: Steve Kondik <shade@chemlab.org>
    Date:   Tue Feb 25 14:02:16 2014 +0100

        settings: Relocate Privacy Guard icons to framework

        * So we can use them in the permission dialog for MODE_ASK

        Change-Id: Ia9bac7dff0bbe91ae48db5d4b0d8f46feb9fdf86

    Author: DvTonder <david.vantonder@gmail.com>
    Date:   Thu Jan 16 19:01:23 2014 -0500

        Settings: Fix up top level "Privacy" section

        Change-Id: Id4dbda10a891c793bc6eb3c42807cc0e3f6092cc

    Author: Danny Baumann <dannybaumann@web.de>
    Date:   Fri Nov 8 13:37:07 2013 +0100

        Add back privacy guard manager.

        Change-Id: Ic9fbbae137bb8425fe72a6cdb2f17117351b5709

    Author: Chirayu Desai <cdesai@cyanogenmod.org>
    Date:   Sat Dec 28 18:51:46 2013 +0530

        PrivacyGuard: Specify a default value in Settings.getInt method call

        * While privacy guard is enabled by default, the default value specified
          here is returned only when the setting is not defined or not an integer.

        Change-Id: Iaedffcc76a23a310aa7915f6a42ccce83ba5d2a6

    Author: Matt Mower <mowerm@gmail.com>
    Date:   Wed Feb 5 19:40:37 2014 -0600

        PrivacyGuard: confirm permissions reset

        The button to reset all application permissions to enabled looks
        suspiciously like a refresh button. Prompt the user with a confirmation
        dialog to make sure they know what they've pressed.

        Change-Id: I0444c5bf8e9533feccf890055d34d3200609c6f6

    Author: Diogo Ferreira <defer@cyngn.com>
    Date:   Wed Dec 17 11:56:22 2014 +0000

        su: Add Root access app-ops control

        Adds an app-ops option for root access.

        Platform-signed apps weren't previously being listed but there are some
        that use root access (FileManager comes to mind).

        So we list all of them, but for platform-signed apps we only show the
        root toggle and none of the permission-based ones.

        Change-Id: Ie716974156d55eb66061e78dc39505569e5bdc2a

    Author: Shashank Mittal <mittals@codeaurora.org>
    Date:   Thu Sep 5 19:01:47 2013 -0700

        AppOps: Add more operations in app ops settings.

        Add following operations in app ops settings.

        -- Wifi enable/disable
        -- Bluetooth enable/disable

        Change-Id: I32183d77b88c326168557444a445765b5a69de6f

        AppOps: Add support for nfc operation

        Add support for nfc operation

        Change-Id: I0ca617b11d3f65f80cc49c3f629312e2fee1ba91

        AppOps: Add mobile data-on permission control.

        Add mobile data-on permission control.

        Change-Id: I0956fb1575addb5f4e522e664a80442120190b86

    Author: Michael Bestas <mikeioannina@gmail.com>
    Date:   Sat Mar 8 03:18:34 2014 +0200

        Settings: Convert AppOps array items to string references

        * Avoid future breakage
         This will need conversion of all AOSP translated arrays to strings

        Change-Id: I2e52e4013d1232d529ce5b9e3aae3502c42e938a

    Author: Shashank Mittal <mittals@codeaurora.org>
    Date:   Thu Mar 6 17:16:49 2014 -0800

        AppOps: Add 'Always ask' option under appOps setting.

        Add always ask option for each operation.

        Change-Id: Ia4f331a5b7d0b1c8ae6946c55a4f78818fe0454f

    Author: Shashank Mittal <mittals@codeaurora.org>
    Date:   Fri Aug 1 13:05:35 2014 -0700

        AppOps: Use switch widget for non-strict ops.

        There are few Ops for which 'Always Ask' mode is not allwoed.
        So use switch widget to control such Ops.

        Change-Id: Ic7464a207c00e4cb9efff57c1f060e04379c1ee7

    Author: Chirayu Desai <cdesai@cyanogenmod.org>
    Date:   Mon Dec 7 14:07:11 2015 -0800

        Allow disabling the privacy guard notification - port from cm-12.1 (1/3)

        Change-Id: Iebf4545c1a65b10036a4865bae29d14e86b12d07

    Author: Roman Birg <roman@cyngn.com>
    Date:   Mon Nov 2 17:34:00 2015 -0800

        Fix advanced privacy guard screen

        Change-Id: I1064f2df748b21384f53219b87645f1569f595d5
        Signed-off-by: Roman Birg <roman@cyngn.com>

    Author: Sam Mortimer <sam@mortimer.me.uk>
    Date:   Thu Oct 3 13:51:31 2013 -0700

        AppOps: menu options to show/hide user and system apps

        Change-Id: Ia55364c361db949a891e4b53a757ee4dff519eb6

    Author: Danny Baumann <dannybaumann@web.de>
    Date:   Wed Oct 2 22:24:14 2013 -0700

        [1/2] AppOps: Show allowed/ignored counts

        Change-Id: Ia27737155c33e934df9a2a1fcff88379240fd096

    Author: Sam Mortimer <sam@mortimer.me.uk>
    Date:   Sun Dec 1 21:39:07 2013 -0800

        AppOps: only apply app type filters to summary screen

        *) If buildState() is called for a single package, do
           not apply hide user/system app filters.
        *) Fixes show detail display when called via
           long press in privacyguard and an AppOp hide
           filter is ticked.

        Change-Id: If31d094fb989836ab6829daeefe820695032c0ed

    Author: Diogo Ferreira <defer@cyngn.com>
    Date:   Mon Jan 5 18:19:12 2015 +0000

        privacyguard: Add Superuser summary

        Adds superuser summary to the privacy guard "Advanced" menu, this
        is useful for auditing purposes. The tab is only visible when root
        for apps is enabled.

        Change-Id: I0b71c51d10e44e69102c311e526cdb1fde9bda26

    Author: Danesh M <daneshm90@gmail.com>
    Date:   Mon Mar 21 13:56:22 2016 -0700

        Settings : Fix default privacy guard preference

        Ensure we write to the correct table.
        CYNGNOS-2264

        Change-Id: I1260cf665080631e3e2ec19b371a79eee273c6d2

    Author: Lars Greiss <kufikugel@googlemail.com>
    Date:   Sat Apr 25 03:15:15 2015 +0300

        Launch app privacy settings when tapping on PG notification (2/2)

        Based on https://github.com/SlimRoms/packages_apps_Settings/commit/46bb1442aa96aad6890e3ce7b6f3c0466ababf25



        JIRA: CYAN-6077
        Change-Id: I8632e8c944c1d5d7ad2fb2a2276bae5fe2d4a0a0

    Author: Michael Bestas <mikeioannina@gmail.com>
    Date:   Mon Jan 12 00:09:26 2015 +0200

        Update privacy guard reset icon

        Change-Id: Ia636b08fea0d21c0185d053ecf601d1ddcf5a828

    Author: jrizzoli <joey@cyanogenmoditalia.it>
    Date:   Fri Apr 24 15:00:28 2015 +0200

        Settings: update dashboard icons

        * Lockscreen: drawable from quicktoggles
        * Performance: chip
        * Privacy: shield
        * Sounds: speaker

        Change-Id: I227778583d073c1d3fdfb727dcc32c949c535847
        Signed-off-by: jrizzoli <joey@cyanogenmoditalia.it>

    Author: blunden <blunden2@gmail.com>
    Date:   Sat Dec 6 20:18:20 2014 +0100

        Update the Privacy category drawable

        Replace the current ones with new vector drawables

        Change-Id: I27a6778d876672c78469b886e2574baa149aad80

    Author: Diogo Ferreira <defer@cyngn.com>
    Date:   Mon Jan 5 17:56:53 2015 +0000

        PrivacyGuard: Tint the enabled icon

        The enabled icon was white and when enabled, the icon would get
        the exact same color as the background, rendering impossible to see.

        Change-Id: I4dc2b52cfca46abf2eff28a0b25918d42cf39f09

    Author: nickdoherty81 <nickdoh81@gmail.com>
    Date:   Mon Jan 5 00:07:56 2015 -0500

        Check boxes to Switches in PrivacyGuardPerfs

        Change-Id: I329df30a6a095a6a5f5829d8b627b00769e18685

    Author: Diogo Ferreira <defer@cyngn.com>
    Date:   Wed Jan 14 16:06:23 2015 +0000

        appops: Load the app list asynchronously

        The AppList is pretty big and it is loading in the UI thread. This
        is noticeable even on high-end chips and there is a definite possibility
        that it throws an ANR on lower-end ones.

        This patchset adds an asynchronous loader and updates the privacy guard
        to use it.

        Change-Id: I81f3fb64604af07a351f8cbdfffa7454389e2cee

    Author: Adnan Begovic <adnan@cyngn.com>
    Date:   Tue Jan 27 18:11:19 2015 -0800

        Settings: Fix off-by-one SectionIndexer in PrivacyGuard.

        Change-Id: If97876214d6f532ca4e5a09f09d881cd4fbf0231

    Author: Adnan Begovic <adnan@cyngn.com>
    Date:   Wed Jan 28 15:53:35 2015 -0800

        Settings: Fix inflate exception on search. Dynamically replace nested fragment.

           When PrivacyGuard is opened, the parent fragment would inflate the layout
           which contained a nested fragment. This is bad behavior. Since we couldn't
           keep track of the fragments lifecycle, the fragment we instantiated during
           inflation would cause an inflate exception if and when we toggled the search
           view within the current context.

           Mitigate the crash by programmatically replacing the fragment after instantiating it once.

           AndroidRuntime
                  E  FATAL EXCEPTION: main
                  E  Process: com.android.settings, PID: 12372
                  E  android.view.InflateException: Binary XML file line #21: Error inflating class fragment
                  E      at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
                  E      at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
                  E      at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
                   ...
                  E  Caused by: java.lang.IllegalArgumentException: Binary XML file line #21: Duplicate id 0x7f1001a2, tag nul
                     l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
                  E      at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
                  E      at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
                  E      at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
                  E      ... 25 more

        Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b

    Author: Steve Kondik <steve@cyngn.com>
    Date:   Mon Mar 9 16:05:32 2015 +0000

        settings: Use consistent headers for Privacy Guard

         * Show "Privacy Guard" instead of "App ops" in advanced settings

        Change-Id: I98107ba3ad94ba22bbd4dc9e92ea97a36f664ab8

    Author: Matt Garnes <matt@cyngn.com>
    Date:   Fri May 15 15:55:44 2015 -0700

        Do not allow privacy guard for core system apps.

        Hide any applications that have the system UID as well as System UI from
        privacy guard. Enabling this on these core apps can have disastrous
        consequences, since many privacy guard authorization requests will queue
        up. This can cause the system process or System UI to be killed when
        they ANR while they wait at the end of a very long queue for the user to authorize them.

        By using privacy guard, you are trusting that the system will control
        and protect these permissions in the first place; there is no need to protect
        the system from itself.

        Change-Id: I478d6a6783a4c06fa7ad01a96c413290b232636c

    Author: Gianmarco Reverberi <gianmarco.reverberi@gmail.com>
    Date:   Tue Jun 2 19:30:45 2015 +0200

        PrivacyGuard: restore ListView position on resume, for real

        ListView gets reloaded each time the activity is resumed,
        so we have to restore the position after LoadManager finishes its job

        Change-Id: I8f05027aaf8ef85481ecb578efa2c2d2c6c6256d

    Author: Roman Birg <roman@cyngn.com>
    Date:   Wed Sep 9 12:05:38 2015 -0700

        Settings: persist privacy guard dialogs across rotates

        Ref: CYNGNOS-933

        Change-Id: I778ff0152dd4a1c0152dca68e82cc89a41f88508
        Signed-off-by: Roman Birg <roman@cyngn.com>

    Author: Steve Kondik <steve@cyngn.com>
    Date:   Mon Sep 12 01:29:07 2016 -0700

        settings: Fix viewpager tabs not showing on AppOpsSummary

        Change-Id: I311c61559177ea733809f510f017ef613915f3d4

    Author: Gabriele M <moto.falcon.git@gmail.com>
    Date:   Wed Mar 15 22:05:46 2017 +0100

        AppOpsDetails: Check app permissions safely

        checkOp() throws a SecurityException when the application is not
        allowed to perform the given operation. Use  checkOpNoThrow() so
        that no exception is thrown. If the operation is not permitted,
        AppOpsManager.MODE_ERRORED will be returned and AppOpsDetails will
        treat it as MODE_IGNORED (i.e. don't allow).

        BUGBASH-52

        Change-Id: Ic3177a24ae52438594e65cd19e29a86c1ee299e8

    Author: Gabriele M <moto.falcon.git@gmail.com>
    Date: Sun Aug 6 13:08:51 2017 +0200

        Settings: Always show Privacy Guard permissions

        Enabling Privacy Guard for an app simply means switching a set of
        operations to MODE_ASK, independently on whether the application
        actually declared those ops (though a permission) or not. The
        framework keeps track only of the ops with a non-default value. As
        consequence, all the ops set by Privacy Guard that aren't declared
        by the app through its manifest are effectively lost when set to
        their default value and the settings won't show them.

        Never hide the Privacy Guard ops to provide a consistent UI.

        Change-Id: Iafcf058f5e2074982bf45f8c82ef8d027b9358f0

    Author: Gabriele M <moto.falcon.git@gmail.com>
    Date: Fri Sep 1 01:46:30 2017 +0200

        AppOpsState: Hide undeclared Privacy Guard OPs

        Since commit f02e0409
        ("Settings: Always show Privacy Guard permissions"), all the Privacy
        Guard OPs are shown independently on whether the application declared
        the associated permission or not. This solved the UI inconsistencies,
        but it's still confusing. Instead of always showing these special OPs,
        hide them, unless unless the application declared the associated
        permission or the OP doesn't have an associated permission.

        Note: if a Privacy Guard OP is not associated to any permission it
        will appear for every application with Privacy Guard enabled,
        bringing back the UI inconsistency solved with f02e0409.
        This doesn't happen with the current set of OPs.

        Change-Id: Iddc92b3547187e24140a328d50c5ac09bc1a7ccfa

   Author: Tobias Tefke <tobias.tefke@gmail.com>
   Date: Sun, 11 Mar 2018 17:58:28 +0100

       Privacy Guard: Add icon for VPN permission

       Change-Id: I5f940c1966f9df755bc2643414b34b0303eac0a1

   Author: Tobias Tefke <tobias.tefke@gmail.com>
   Date: Sun, 11 Mar 2018 11:33:37 +0100

       Privacy Guard: Avoid NPE when tinting permission icons

       If PG can't retrieve the icon for a certain permission, a null reference
       is returned. If tint is being set afterwards, a NPE will be thrown.

   Change-Id: I266579ad60e6d0fc3323d07bcd9bcd9c0d4bd990

   Author: Dan Pasanen <dan.pasanen@gmail.com>
   Date: Thu, 15 Mar 2018 20:40:44 -0500

       PrivacyGuard: add a couple more missing icons

       * Add new icon for "Turn on screen" (ic_phone_android from
         https://github.com/google/material-design-icons)

       * Use music note icon for media volume

       Change-Id: I9c8d314906b973319c7aeb7d0d173c7a12925b94

Change-Id: Id810e21d735adcf8fb8c32519828ef9a23f3e684

parent 0bb18f7d

AndroidManifest.xml

+39 −0

Original line number	Diff line number	Diff line
		@@ -1270,6 +1270,21 @@
		</intent-filter>
		</activity>

		<activity android:name="Settings$AppOpsSummaryActivity"
		android:label="@*lineageos.platform:string/privacy_guard_manager_title"
		android:taskAffinity=""
		android:excludeFromRecents="true">
		<intent-filter>
		<action android:name="android.intent.action.MAIN" />
		<action android:name="android.settings.APP_OPS_SETTINGS" />
		<category android:name="android.intent.category.DEFAULT" />
		<category android:name="android.intent.category.VOICE_LAUNCH" />
		<category android:name="com.android.settings.SHORTCUT" />
		</intent-filter>
		<meta-data android:name="com.android.settings.FRAGMENT_CLASS"
		android:value="com.android.settings.applications.appops.AppOpsSummary" />
		</activity>

		<activity android:name="Settings$BackgroundCheckSummaryActivity"
		android:label="@string/background_check_title"
		android:enabled="false">
		@@ -1281,6 +1296,30 @@
		android:value="com.android.settings.applications.appops.BackgroundCheckSummary" />
		</activity>

		<!-- Still need a top-level activity for showing app ops details. Aliasing
		trick is so the code that is now a fragment can still be called
		AppOpsDetails. -->
		<activity android:name=".applications.appops.AppOpsDetailsTop"
		android:label="@*lineageos.platform:string/privacy_guard_manager_title"
		android:exported="true"
		android:taskAffinity=""
		android:excludeFromRecents="true"
		android:parentActivityName="Settings$AppOpsSummaryActivity">
		</activity>

		<!-- Keep compatibility with old shortcuts. -->
		<activity-alias android:name=".applications.appops.AppOpsDetails"
		android:label="@*lineageos.platform:string/privacy_guard_manager_title"
		android:exported="true"
		android:excludeFromRecents="true"
		android:targetActivity=".applications.appops.AppOpsDetailsTop">
		<intent-filter>
		<action android:name="android.settings.APP_OPS_DETAILS_SETTINGS" />
		<category android:name="android.intent.category.DEFAULT" />
		<data android:scheme="package" />
		</intent-filter>
		</activity-alias>

		<activity
		android:name="Settings$LocationSettingsActivity"
		android:label="@string/location_settings_title"

proguard.flags

+2 −0

Original line number	Diff line number	Diff line
		@@ -29,6 +29,8 @@
		*** get*();
		}

		-keep class com.android.settings.lineageos.*Settings

		# Keep classes that may be inflated from XML.
		-keepclasseswithmembers class * {
		public <init>(android.content.Context, android.util.AttributeSet);

res/drawable/ic_perm_alarm.xml

0 → 100644

+25 −0

Original line number	Diff line number	Diff line
		<!--
		Copyright (C) 2016 The Android Open Source Project

		Licensed under the Apache License, Version 2.0 (the "License");
		you may not use this file except in compliance with the License.
		You may obtain a copy of the License at

		http://www.apache.org/licenses/LICENSE-2.0

		Unless required by applicable law or agreed to in writing, software
		distributed under the License is distributed on an "AS IS" BASIS,
		WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		See the License for the specific language governing permissions and
		limitations under the License.
		-->
		<vector xmlns:android="http://schemas.android.com/apk/res/android"
		android:height="24.0dp"
		android:width="24.0dp"
		android:viewportWidth="24.0"
		android:viewportHeight="24.0"
		android:tint="#FF000000">
		<path
		android:fillColor="#FF000000"
		android:pathData="M12,20A7,7 0 0,1 5,13A7,7 0 0,1 12,6A7,7 0 0,1 19,13A7,7 0 0,1 12,20M12,4A9,9 0 0,0 3,13A9,9 0 0,0 12,22A9,9 0 0,0 21,13A9,9 0 0,0 12,4M12.5,8H11V14L15.75,16.85L16.5,15.62L12.5,13.25V8M7.88,3.39L6.6,1.86L2,5.71L3.29,7.24L7.88,3.39M22,5.72L17.4,1.86L16.11,3.39L20.71,7.25L22,5.72Z" />
		</vector>

res/drawable/ic_perm_audio.xml

0 → 100644

+25 −0

Original line number	Diff line number	Diff line
		<!--
		Copyright (C) 2016 The Android Open Source Project

		Licensed under the Apache License, Version 2.0 (the "License");
		you may not use this file except in compliance with the License.
		You may obtain a copy of the License at

		http://www.apache.org/licenses/LICENSE-2.0

		Unless required by applicable law or agreed to in writing, software
		distributed under the License is distributed on an "AS IS" BASIS,
		WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		See the License for the specific language governing permissions and
		limitations under the License.
		-->
		<vector xmlns:android="http://schemas.android.com/apk/res/android"
		android:width="24.0dp"
		android:height="24.0dp"
		android:viewportWidth="24.0"
		android:viewportHeight="24.0"
		android:tint="#FF000000">
		<path
		android:fillColor="#FF000000"
		android:pathData="M 12 3 v 9.28 c -0.47 -0.17 -0.97 -0.28 -1.5 -0.28 C 8.01 12 6 14.01 6 16.5 S 8.01 21 10.5 21 c 2.31 0 4.2 -1.75 4.45 -4 H 15 V 6 h 4 V 3 h -7 Z"/>
		</vector>

res/drawable/ic_perm_background.xml

0 → 100644

+25 −0

Original line number	Diff line number	Diff line
		<!--
		Copyright (C) 2016 The Android Open Source Project

		Licensed under the Apache License, Version 2.0 (the "License");
		you may not use this file except in compliance with the License.
		You may obtain a copy of the License at

		http://www.apache.org/licenses/LICENSE-2.0

		Unless required by applicable law or agreed to in writing, software
		distributed under the License is distributed on an "AS IS" BASIS,
		WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		See the License for the specific language governing permissions and
		limitations under the License.
		-->
		<vector xmlns:android="http://schemas.android.com/apk/res/android"
		android:width="24.0dp"
		android:height="24.0dp"
		android:viewportWidth="24.0"
		android:viewportHeight="24.0"
		android:tint="#FF000000">
		<path
		android:fillColor="#FF000000"
		android:pathData="M 9 7 H 7 v 2 h 2 V 7 Z m 0 4 H 7 v 2 h 2 v -2 Z m 0 -8 c -1.11 0 -2 0.9 -2 2 h 2 V 3 Z m 4 12 h -2 v 2 h 2 v -2 Z m 6 -12 v 2 h 2 c 0 -1.1 -0.9 -2 -2 -2 Z m -6 0 h -2 v 2 h 2 V 3 Z M 9 17 v -2 H 7 c 0 1.1 0.89 2 2 2 Z m 10 -4 h 2 v -2 h -2 v 2 Z m 0 -4 h 2 V 7 h -2 v 2 Z m 0 8 c 1.1 0 2 -0.9 2 -2 h -2 v 2 Z M 5 7 H 3 v 12 c 0 1.1 0.89 2 2 2 h 12 v -2 H 5 V 7 Z m 10 -2 h 2 V 3 h -2 v 2 Z m 0 12 h 2 v -2 h -2 v 2 Z"/>
		</vector>