Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b8a5d1e authored by Tsung-Mao Fang's avatar Tsung-Mao Fang
Browse files

Fix GAR color constrast issue on dialog 

Based on the UX definition, assign correct error color
for dialog

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I338570b38c6fc5fa32ea1becd069084bf2d631a6
parent 958e5873

color-check-baseline.xml

+269 −573

File changed.

Preview size limit exceeded, changes collapsed.

res/values-night/colors.xml

+2 −0
Original line number Diff line number Diff line
@@ -39,5 +39,7 @@ 
    <color name="gestures_setting_background_color">@android:color/black</color>



    <color name="color_surface_header">@*android:color/surface_header_dark</color>

    <!-- Dialog error color. -->

    <color name="settings_dialog_colorError">#f28b82</color> <!-- Red 300 -->

</resources>

res/values/colors.xml

+2 −0
Original line number Diff line number Diff line
@@ -198,4 +198,6 @@ 
    <color name="accessibility_color_inversion_background">#546E7A</color>



    <color name="battery_info_error_color_red">#fce8e6</color> <!-- Material Red 50 -->

    <!-- Dialog error color. -->

    <color name="settings_dialog_colorError">#d93025</color> <!-- Red 600 -->

</resources>

res/values/themes.xml

+1 −0
Original line number Diff line number Diff line
@@ -130,6 +130,7 @@ 


    <style name="Theme.AlertDialog.Base" parent="@style/Theme.AppCompat.DayNight.Dialog.Alert">

        <item name="colorAccent">@*android:color/accent_device_default_light</item>

        <item name="android:colorError">@color/settings_dialog_colorError</item>

        <item name="android:colorBackground">?androidprv:attr/colorSurface</item>

    </style>