Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 688c5c90 authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Update the 'is valid contentIntent' check 

Existing check required that the original request code be 0,
but that's not actually required for the intent to work on this
page

Test: tap on email notification in history, be brought to email
page and not main email list page
Fixes: 232495202

Change-Id: I120022535ddbde19003f2db6f1b81a983d00789d
parent 9c3c55ec

src/com/android/settings/notification/history/NotificationSbnViewHolder.java

+1 −3
Original line number Diff line number Diff line
@@ -98,9 +98,7 @@ public class NotificationSbnViewHolder extends RecyclerView.ViewHolder { 
            boolean isSnoozed, UiEventLogger uiEventLogger) {

        Intent appIntent = itemView.getContext().getPackageManager()

                .getLaunchIntentForPackage(pkg);

        boolean isPendingIntentValid = pi != null && PendingIntent.getActivity(

                itemView.getContext(), 0, pi.getIntent(),

                PendingIntent.FLAG_IMMUTABLE | PendingIntent.FLAG_NO_CREATE) != null;

        boolean isPendingIntentValid = pi != null && pi.isActivity();

        if (isPendingIntentValid || appIntent != null) {

            itemView.setOnClickListener(v -> {

                uiEventLogger.logWithInstanceIdAndPosition(