Disallow downgrade of bundled home apps (568eeca5) · Commits · e / os / android_packages_apps_Settings

src/com/android/settings/applications/InstalledAppDetails.java

+22 −13

Original line number	Diff line number	Diff line
		@@ -347,11 +347,12 @@ public class InstalledAppDetails extends Fragment

		private void initUninstallButtons() {
		mUpdatedSysApp = (mAppEntry.info.flags & ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0;
		final boolean isBundled = (mAppEntry.info.flags & ApplicationInfo.FLAG_SYSTEM) != 0;
		boolean enabled = true;
		if (mUpdatedSysApp) {
		mUninstallButton.setText(R.string.app_factory_reset);
		boolean showSpecialDisable = false;
		if ((mAppEntry.info.flags & ApplicationInfo.FLAG_SYSTEM) != 0) {
		if (isBundled) {
		showSpecialDisable = handleDisableable(mSpecialDisableButton);
		mSpecialDisableButton.setOnClickListener(this);
		}
		@@ -361,7 +362,7 @@ public class InstalledAppDetails extends Fragment
		mMoreControlButtons.setVisibility(showSpecialDisable ? View.VISIBLE : View.GONE);
		} else {
		mMoreControlButtons.setVisibility(View.GONE);
		if ((mAppEntry.info.flags & ApplicationInfo.FLAG_SYSTEM) != 0) {
		if (isBundled) {
		enabled = handleDisableable(mUninstallButton);
		} else if ((mPackageInfo.applicationInfo.flags
		& ApplicationInfo.FLAG_INSTALLED) == 0
		@@ -380,9 +381,16 @@ public class InstalledAppDetails extends Fragment
		enabled = false;
		}

		// If this is the default (or only) home app, suppress uninstall (even if
		// we still think it should be allowed for other reasons)
		// Home apps need special handling. Bundled ones we don't risk downgrading
		// because that can interfere with home-key resolution. Furthermore, we
		// can't allow uninstallation of the only home app, and we don't want to
		// allow uninstallation of an explicitly preferred one -- the user can go
		// to Home settings and pick a different one, after which we'll permit
		// uninstallation of the now-not-default one.
		if (enabled && mHomePackages.contains(mPackageInfo.packageName)) {
		if (isBundled) {
		enabled = false;
		} else {
		ArrayList<ResolveInfo> homeActivities = new ArrayList<ResolveInfo>();
		ComponentName currentDefaultHome = mPm.getHomeActivities(homeActivities);
		if (currentDefaultHome == null) {
		@@ -395,6 +403,7 @@ public class InstalledAppDetails extends Fragment
		enabled = !mPackageInfo.packageName.equals(currentDefaultHome.getPackageName());
		}
		}
		}

		if (mAppControlRestricted) {
		enabled = false;