Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5209a10e authored by menghanli's avatar menghanli
Browse files

Remove obsoleted code: DividerAllowedBelowPreference

Settings don't show divider in material design. The DividerAllowedBelowPreference is not used now.

Bug: 197695932
Test: make RunSettingsRoboTest
Change-Id: Id2b28f76c4ed8c429594bf786690499fb3f2503a
parent 60ecf13e
Loading
Loading
Loading
Loading
+0 −47
Original line number Diff line number Diff line
/*
 * Copyright (C) 2016 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.settings.accessibility;

import android.content.Context;
import android.util.AttributeSet;

import androidx.preference.Preference;
import androidx.preference.PreferenceViewHolder;

/*
 * Preference that always has a divider below. Used for SUW Accessibility Settings Summary text.
 */
public class DividerAllowedBelowPreference extends Preference {
    public DividerAllowedBelowPreference(Context context) {
        super(context);
    }

    public DividerAllowedBelowPreference(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    public DividerAllowedBelowPreference(Context context, AttributeSet attrs, int defStyleAttrs) {
        super(context, attrs, defStyleAttrs);
    }

    @Override
    public void onBindViewHolder(PreferenceViewHolder holder) {
        super.onBindViewHolder(holder);
        holder.setDividerAllowedBelow(true);
    }
}
+0 −61
Original line number Diff line number Diff line
/*
 * Copyright (C) 2020 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.settings.accessibility;

import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.internal.verification.VerificationModeFactory.times;

import android.content.Context;
import android.view.LayoutInflater;
import android.view.View;

import androidx.preference.PreferenceViewHolder;

import com.android.settings.R;

import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;

/** Tests for {@link DividerAllowedBelowPreference}. */
@RunWith(RobolectricTestRunner.class)
public class DividerAllowedBelowPreferenceTest {
    private final Context mContext = RuntimeEnvironment.application;
    private PreferenceViewHolder mViewHolder;

    @Before
    public void setUp() {
        final LayoutInflater inflater = LayoutInflater.from(mContext);
        final View rootView =
                inflater.inflate(R.layout.preference, /* root= */ null);
        mViewHolder = spy(PreferenceViewHolder.createInstanceForTests(rootView));
    }

    @Test
    public void onBindViewHolder_dividerAllowedBelow() {
        final DividerAllowedBelowPreference dividerAllowedBelowPreference =
                new DividerAllowedBelowPreference(mContext);

        dividerAllowedBelowPreference.onBindViewHolder(mViewHolder);

        // One time was in parent, the other time was in child.
        verify(mViewHolder, times(2)).setDividerAllowedBelow(true);
    }
}