Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 506c3e04 authored by Jack Yu's avatar Jack Yu
Browse files

Cleaned up the flag enable_identifier_disclosure_transparency 

Cleaned up the 24Q3 flag enable_identifier_disclosure_transparency

Bug: 276752426
Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Flag: EXEMPT removing flag
Change-Id: Id3355ef2416f75df8ca43cc4d261583e92c17fba
parent 96d615ad

src/com/android/settings/network/CellularSecurityPreferenceController.java

+0 −1
Original line number Diff line number Diff line
@@ -72,7 +72,6 @@ public class CellularSecurityPreferenceController extends BasePreferenceControll 
        if (!mContext.getPackageManager().hasSystemFeature(PackageManager.FEATURE_TELEPHONY)

                || !Flags.enableIdentifierDisclosureTransparencyUnsolEvents()

                || !Flags.enableModemCipherTransparencyUnsolEvents()

                || !Flags.enableIdentifierDisclosureTransparency()

                || !Flags.enableModemCipherTransparency()) {

            return UNSUPPORTED_ON_DEVICE;

        }

src/com/android/settings/network/telephony/CellularSecurityNotificationsDividerController.java

+0 −1
Original line number Diff line number Diff line
@@ -62,7 +62,6 @@ public class CellularSecurityNotificationsDividerController extends 
    public int getAvailabilityStatus() {

        if (!Flags.enableIdentifierDisclosureTransparencyUnsolEvents()

                || !Flags.enableModemCipherTransparencyUnsolEvents()

                || !Flags.enableIdentifierDisclosureTransparency()

                || !Flags.enableModemCipherTransparency()) {

            return UNSUPPORTED_ON_DEVICE;

        }

src/com/android/settings/network/telephony/CellularSecurityNotificationsPreferenceController.java

+0 −1
Original line number Diff line number Diff line
@@ -180,7 +180,6 @@ public class CellularSecurityNotificationsPreferenceController extends 
    private boolean areFlagsEnabled() {

        if (!Flags.enableIdentifierDisclosureTransparencyUnsolEvents()

                || !Flags.enableModemCipherTransparencyUnsolEvents()

                || !Flags.enableIdentifierDisclosureTransparency()

                || !Flags.enableModemCipherTransparency()) {

            return false;

        }

tests/unit/src/com/android/settings/network/CellularSecurityPreferenceControllerTest.java

+0 −4
Original line number Diff line number Diff line
@@ -169,15 +169,11 @@ public final class CellularSecurityPreferenceControllerTest { 
            mSetFlagsRule.enableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.enableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY);

            mSetFlagsRule.enableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY);

        } else {

            mSetFlagsRule.disableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.disableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.disableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY);

            mSetFlagsRule.disableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY);

        }

    }

}

tests/unit/src/com/android/settings/network/telephony/CellularSecurityNotificationsDividerControllerTest.java

+0 −4
Original line number Diff line number Diff line
@@ -129,15 +129,11 @@ public class CellularSecurityNotificationsDividerControllerTest { 
            mSetFlagsRule.enableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.enableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY);

            mSetFlagsRule.enableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY);

        } else {

            mSetFlagsRule.disableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.disableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY_UNSOL_EVENTS);

            mSetFlagsRule.disableFlags(Flags.FLAG_ENABLE_MODEM_CIPHER_TRANSPARENCY);

            mSetFlagsRule.disableFlags(

                    Flags.FLAG_ENABLE_IDENTIFIER_DISCLOSURE_TRANSPARENCY);

        }

    }

}