Merge "Support GLIF v3 for lock screen settings" (4d869f28) · Commits · e / os / android_packages_apps_Settings

color-check-baseline.xml

+87 −151

Original line number	Diff line number	Diff line
		@@ -257,38 +257,6 @@
		column="5"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		message="Avoid using hardcoded color"
		category="Correctness"
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <color name="setup_divider_color_dark">#33ffffff</color>"
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="33"
		column="5"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		message="Avoid using hardcoded color"
		category="Correctness"
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <color name="setup_divider_color_light">#33000000</color>"
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="34"
		column="5"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		@@ -301,7 +269,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="35"
		line="33"
		column="5"/>
		</issue>

		@@ -317,7 +285,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="37"
		line="35"
		column="5"/>
		</issue>

		@@ -333,7 +301,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="39"
		line="37"
		column="5"/>
		</issue>

		@@ -349,7 +317,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="40"
		line="38"
		column="5"/>
		</issue>

		@@ -365,7 +333,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="41"
		line="39"
		column="5"/>
		</issue>

		@@ -381,7 +349,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="43"
		line="41"
		column="5"/>
		</issue>

		@@ -397,7 +365,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="44"
		line="42"
		column="5"/>
		</issue>

		@@ -413,7 +381,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="46"
		line="44"
		column="5"/>
		</issue>

		@@ -429,7 +397,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="51"
		line="49"
		column="5"/>
		</issue>

		@@ -445,7 +413,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="52"
		line="50"
		column="5"/>
		</issue>

		@@ -461,7 +429,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="53"
		line="51"
		column="5"/>
		</issue>

		@@ -477,7 +445,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="55"
		line="53"
		column="5"/>
		</issue>

		@@ -493,7 +461,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="56"
		line="54"
		column="5"/>
		</issue>

		@@ -509,7 +477,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="58"
		line="56"
		column="5"/>
		</issue>

		@@ -525,7 +493,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="61"
		line="59"
		column="5"/>
		</issue>

		@@ -541,7 +509,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="62"
		line="60"
		column="5"/>
		</issue>

		@@ -557,7 +525,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="66"
		line="64"
		column="5"/>
		</issue>

		@@ -573,7 +541,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="67"
		line="65"
		column="5"/>
		</issue>

		@@ -589,7 +557,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="68"
		line="66"
		column="5"/>
		</issue>

		@@ -605,7 +573,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="69"
		line="67"
		column="5"/>
		</issue>

		@@ -621,7 +589,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="71"
		line="69"
		column="5"/>
		</issue>

		@@ -637,7 +605,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="74"
		line="72"
		column="5"/>
		</issue>

		@@ -653,7 +621,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="76"
		line="74"
		column="5"/>
		</issue>

		@@ -669,7 +637,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="77"
		line="75"
		column="5"/>
		</issue>

		@@ -685,7 +653,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="80"
		line="78"
		column="5"/>
		</issue>

		@@ -701,7 +669,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="81"
		line="79"
		column="5"/>
		</issue>

		@@ -717,7 +685,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="82"
		line="80"
		column="5"/>
		</issue>

		@@ -733,7 +701,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="83"
		line="81"
		column="5"/>
		</issue>

		@@ -749,7 +717,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="84"
		line="82"
		column="5"/>
		</issue>

		@@ -765,7 +733,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="87"
		line="85"
		column="5"/>
		</issue>

		@@ -781,7 +749,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="88"
		line="86"
		column="5"/>
		</issue>

		@@ -797,7 +765,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="89"
		line="87"
		column="5"/>
		</issue>

		@@ -813,7 +781,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="90"
		line="88"
		column="5"/>
		</issue>

		@@ -829,7 +797,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="91"
		line="89"
		column="5"/>
		</issue>

		@@ -845,7 +813,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="92"
		line="90"
		column="5"/>
		</issue>

		@@ -861,7 +829,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="93"
		line="91"
		column="5"/>
		</issue>

		@@ -877,7 +845,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="94"
		line="92"
		column="5"/>
		</issue>

		@@ -893,7 +861,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="95"
		line="93"
		column="5"/>
		</issue>

		@@ -909,7 +877,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="96"
		line="94"
		column="5"/>
		</issue>

		@@ -925,7 +893,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="97"
		line="95"
		column="5"/>
		</issue>

		@@ -941,7 +909,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="100"
		line="98"
		column="5"/>
		</issue>

		@@ -957,7 +925,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="102"
		line="100"
		column="5"/>
		</issue>

		@@ -973,7 +941,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="105"
		line="103"
		column="5"/>
		</issue>

		@@ -989,7 +957,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="107"
		line="105"
		column="5"/>
		</issue>

		@@ -1005,7 +973,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="110"
		line="108"
		column="5"/>
		</issue>

		@@ -1021,7 +989,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="113"
		line="111"
		column="5"/>
		</issue>

		@@ -1037,7 +1005,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="116"
		line="114"
		column="5"/>
		</issue>

		@@ -1053,7 +1021,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="119"
		line="117"
		column="5"/>
		</issue>

		@@ -1069,7 +1037,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="120"
		line="118"
		column="5"/>
		</issue>

		@@ -1085,7 +1053,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="123"
		line="121"
		column="5"/>
		</issue>

		@@ -1101,7 +1069,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="124"
		line="122"
		column="5"/>
		</issue>

		@@ -1117,7 +1085,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="125"
		line="123"
		column="5"/>
		</issue>

		@@ -1133,7 +1101,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="126"
		line="124"
		column="5"/>
		</issue>

		@@ -1149,7 +1117,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="127"
		line="125"
		column="5"/>
		</issue>

		@@ -1165,7 +1133,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="128"
		line="126"
		column="5"/>
		</issue>

		@@ -1181,7 +1149,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="129"
		line="127"
		column="5"/>
		</issue>

		@@ -1197,7 +1165,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="130"
		line="128"
		column="5"/>
		</issue>

		@@ -1213,7 +1181,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="131"
		line="129"
		column="5"/>
		</issue>

		@@ -1229,7 +1197,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="132"
		line="130"
		column="5"/>
		</issue>

		@@ -1245,7 +1213,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="133"
		line="131"
		column="5"/>
		</issue>

		@@ -1261,7 +1229,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="134"
		line="132"
		column="5"/>
		</issue>

		@@ -1277,7 +1245,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/colors.xml"
		line="135"
		line="133"
		column="5"/>
		</issue>

		@@ -2493,7 +2461,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values-en-rAU/strings.xml"
		line="2354"
		line="2395"
		column="64"/>
		</issue>

		@@ -2509,7 +2477,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values-en-rCA/strings.xml"
		line="2354"
		line="2395"
		column="64"/>
		</issue>

		@@ -2525,7 +2493,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values-en-rGB/strings.xml"
		line="2354"
		line="2395"
		column="64"/>
		</issue>

		@@ -2541,7 +2509,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values-en-rIN/strings.xml"
		line="2354"
		line="2395"
		column="64"/>
		</issue>

		@@ -2573,7 +2541,7 @@
		errorLine2=" ~~~~~~~~~~~~~~~~~~~">
		<location
		file="res/values/strings.xml"
		line="5651"
		line="5638"
		column="36"/>
		</issue>

		@@ -2665,12 +2633,12 @@
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <item name="setup_divider_color">@color/setup_divider_color_dark</item>"
		errorLine1=" <item name="wifi_signal_color">@color/setup_wizard_wifi_color_dark</item>"
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="33"
		column="42"/>
		column="40"/>
		</issue>

		<issue
		@@ -2681,11 +2649,11 @@
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <item name="wifi_signal_color">@color/setup_wizard_wifi_color_dark</item>"
		errorLine1=" <item name="wifi_signal_color">@color/setup_wizard_wifi_color_light</item>"
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="35"
		line="52"
		column="40"/>
		</issue>

		@@ -2697,12 +2665,12 @@
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <item name="setup_divider_color">@color/setup_divider_color_light</item>"
		errorLine1=" <item name="wifi_signal_color">@color/setup_wizard_wifi_color_dark</item>"
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="53"
		column="42"/>
		line="70"
		column="40"/>
		</issue>

		<issue
		@@ -2717,26 +2685,10 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="55"
		line="89"
		column="40"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		message="Avoid using hardcoded color"
		category="Correctness"
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <item name="setup_divider_color">@color/setup_divider_color_dark</item>"
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="72"
		column="42"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		@@ -2749,26 +2701,10 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="74"
		line="107"
		column="40"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		message="Avoid using hardcoded color"
		category="Correctness"
		priority="4"
		summary="Using hardcoded color"
		explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
		errorLine1=" <item name="setup_divider_color">@color/setup_divider_color_light</item>"
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="92"
		column="42"/>
		</issue>

		<issue
		id="HardCodedColor"
		severity="Error"
		@@ -2781,7 +2717,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="94"
		line="126"
		column="40"/>
		</issue>

		@@ -2797,7 +2733,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="154"
		line="200"
		column="43"/>
		</issue>

		@@ -2813,7 +2749,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="155"
		line="201"
		column="42"/>
		</issue>

		@@ -2829,7 +2765,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="156"
		line="202"
		column="45"/>
		</issue>

		@@ -2845,7 +2781,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="233"
		line="279"
		column="47"/>
		</issue>

		@@ -2861,7 +2797,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="308"
		line="347"
		column="45"/>
		</issue>

		@@ -2877,7 +2813,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="309"
		line="348"
		column="49"/>
		</issue>

		@@ -2893,7 +2829,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="317"
		line="356"
		column="45"/>
		</issue>

		@@ -2909,7 +2845,7 @@
		errorLine2=" ^">
		<location
		file="res/values/themes.xml"
		line="318"
		line="357"
		column="49"/>
		</issue>

res/values/colors.xml

+0 −2

Original line number	Diff line number	Diff line
		@@ -30,8 +30,6 @@

		<color name="divider_color">#20ffffff</color>
		<color name="title_color">@android:color/holo_blue_light</color>
		<color name="setup_divider_color_dark">#33ffffff</color>
		<color name="setup_divider_color_light">#33000000</color>
		<color name="setup_lock_pattern_view_regular_color_dark">#ffbdbdbd</color>
		<color name="setup_lock_pattern_view_regular_color_light">@color/lock_pattern_view_regular_color</color>
		<color name="setup_lock_pattern_view_success_color_dark">#ff84ffff</color>

res/values/themes.xml

+51 −12

File changed.

Preview size limit exceeded, changes collapsed.

src/com/android/settings/SetupWizardUtils.java

+9 −1

File changed.

Preview size limit exceeded, changes collapsed.

src/com/android/settings/fingerprint/FingerprintEnrollBase.java

+0 −1

Original line number	Diff line number	Diff line
		@@ -48,7 +48,6 @@ public abstract class FingerprintEnrollBase extends InstrumentedActivity
		@Override
		protected void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		setTheme(R.style.Theme_FingerprintEnroll);
		mToken = getIntent().getByteArrayExtra(
		ChooseLockSettingsHelper.EXTRA_KEY_CHALLENGE_TOKEN);
		if (savedInstanceState != null && mToken == null) {