Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ccbe5d7 authored by SongFerngWang's avatar SongFerngWang
Browse files

Change the behavior of notifyAllowedNetworkTypesChanged. 

Bug: 180903931
Test: atest AllowedNetworkTypesListenerTest.java
Change-Id: Ic94816415920bf25896ef2b198e228f369039c94
parent 0b29ebd4

src/com/android/settings/network/AllowedNetworkTypesListener.java

+4 −4
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ import android.util.Log; 


import androidx.annotation.VisibleForTesting;



import java.util.Map;

import java.util.concurrent.Executor;
@@ -72,9 +71,10 @@ public class AllowedNetworkTypesListener extends TelephonyCallback implements 
    }



    @Override

    public void onAllowedNetworkTypesChanged(Map<Integer, Long> allowedNetworkTypesList) {

        long newAllowedNetworkType = allowedNetworkTypesList.get(

                TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER);

    public void onAllowedNetworkTypesChanged(int reason, long newAllowedNetworkType) {

        if (reason != TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER) {

            return;

        }

        if (mListener != null && mAllowedNetworkType != newAllowedNetworkType) {

            mListener.onAllowedNetworkTypesChanged();

            Log.d(LOG_TAG, "onAllowedNetworkChanged: " + mAllowedNetworkType);

tests/unit/src/com/android/settings/network/AllowedNetworkTypesListenerTest.java

+3 −7
Original line number Diff line number Diff line
@@ -40,9 +40,6 @@ import org.junit.runner.RunWith; 
import org.mockito.Mock;

import org.mockito.MockitoAnnotations;



import java.util.HashMap;

import java.util.Map;



@RunWith(AndroidJUnit4.class)

public class AllowedNetworkTypesListenerTest {
@@ -73,12 +70,11 @@ public class AllowedNetworkTypesListenerTest { 
    @Test

    public void onChange_shouldCallListener() {

        mAllowedNetworkTypesListener.mListener = mListener;

        Map<Integer, Long> allowedNetworkTypesList = new HashMap<>();

        long networkType = (long) RadioAccessFamily.getRafFromNetworkType(

                TelephonyManager.NETWORK_MODE_LTE_CDMA_EVDO);

        allowedNetworkTypesList.put(TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER,

                networkType);

        mAllowedNetworkTypesListener.onAllowedNetworkTypesChanged(allowedNetworkTypesList);



        mAllowedNetworkTypesListener.onAllowedNetworkTypesChanged(

                TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER, networkType);



        verify(mListener).onAllowedNetworkTypesChanged();

    }