Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bb25335 authored by Antony Sargent's avatar Antony Sargent
Browse files

Fix two problems related to data connectivity in the multi-SIM header 

When you have multiple active SIMs, the Network & internet page has a
header showing entries for each one, with summary text indicating which
one is used for data (and whether it is just set as the default, or
actively using data). We were not properly setting this text when either
data wasn't being used, eg when connected to wifi, or mobile data was
disabled for this SIM. This CL fixes both these problems by adding new
helper classes to listen for relevant events.

Test: make RunSettingsRoboTests
Fixes: 124394250
Fixes: 128857712
Change-Id: I34f2679752fa41a50247dd0b12581cbfd77a34f6
parent 02a54a01

src/com/android/settings/network/MobileDataEnabledListener.java

0 → 100644
+69 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License

 */



package com.android.settings.network;



import android.content.Context;

import android.database.ContentObserver;

import android.net.Uri;

import android.os.Handler;

import android.provider.Settings;

import android.telephony.SubscriptionManager;



/** Helper class to listen for changes in the enabled state of mobile data. */

public class MobileDataEnabledListener extends ContentObserver {

    private Context mContext;

    private Client mClient;

    private int mSubId;



    public interface Client {

        void onMobileDataEnabledChange();

    }



    public MobileDataEnabledListener(Context context, Client client) {

        super(new Handler());

        mContext = context;

        mClient = client;

        mSubId = SubscriptionManager.INVALID_SUBSCRIPTION_ID;

    }



    /** Starts listening to changes in the enabled state for data on the given subscription id. */

    public void start(int subId) {

        mSubId = subId;

        Uri uri;

        if (mSubId == SubscriptionManager.INVALID_SUBSCRIPTION_ID) {

            uri = Settings.Global.getUriFor(Settings.Global.MOBILE_DATA);

        }  else {

            uri = Settings.Global.getUriFor(Settings.Global.MOBILE_DATA + mSubId);

        }

        mContext.getContentResolver().registerContentObserver(uri, true /*notifyForDescendants*/,

                this);

    }



    public int getSubId() {

        return mSubId;

    }



    public MobileDataEnabledListener stop() {

        mContext.getContentResolver().unregisterContentObserver(this);

        return this;

    }



    @Override

    public void onChange(boolean selfChange) {

        mClient.onMobileDataEnabledChange();

    }

}

src/com/android/settings/network/SubscriptionsPreferenceController.java

+48 −4
Original line number Diff line number Diff line
@@ -21,6 +21,9 @@ import static androidx.lifecycle.Lifecycle.Event.ON_RESUME; 


import android.content.Context;

import android.content.Intent;

import android.net.ConnectivityManager;

import android.net.Network;

import android.net.NetworkCapabilities;

import android.provider.Settings;

import android.telephony.SubscriptionInfo;

import android.telephony.SubscriptionManager;
@@ -35,6 +38,7 @@ import androidx.preference.PreferenceGroup; 
import androidx.preference.PreferenceScreen;



import com.android.settings.R;

import com.android.settings.network.telephony.DataConnectivityListener;

import com.android.settings.network.telephony.MobileNetworkActivity;

import com.android.settingslib.core.AbstractPreferenceController;
@@ -46,14 +50,18 @@ import java.util.Map; 
 * available if there are 2 or more subscriptions.

 */

public class SubscriptionsPreferenceController extends AbstractPreferenceController implements

        LifecycleObserver, SubscriptionsChangeListener.SubscriptionsChangeListenerClient {

        LifecycleObserver, SubscriptionsChangeListener.SubscriptionsChangeListenerClient,

        MobileDataEnabledListener.Client, DataConnectivityListener.Client {

    private static final String TAG = "SubscriptionsPrefCntrlr";



    private UpdateListener mUpdateListener;

    private String mPreferenceGroupKey;

    private PreferenceGroup mPreferenceGroup;

    private SubscriptionManager mManager;

    private ConnectivityManager mConnectivityManager;

    private SubscriptionsChangeListener mSubscriptionsListener;

    private MobileDataEnabledListener mDataEnabledListener;

    private DataConnectivityListener mConnectivityListener;



    // Map of subscription id to Preference

    private Map<Integer, Preference> mSubscriptionPreferences;
@@ -89,20 +97,27 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl 
        mPreferenceGroupKey = preferenceGroupKey;

        mStartOrder = startOrder;

        mManager = context.getSystemService(SubscriptionManager.class);

        mConnectivityManager = mContext.getSystemService(ConnectivityManager.class);

        mSubscriptionPreferences = new ArrayMap<>();

        mSubscriptionsListener = new SubscriptionsChangeListener(context, this);

        mDataEnabledListener = new MobileDataEnabledListener(context, this);

        mConnectivityListener = new DataConnectivityListener(context, this);

        lifecycle.addObserver(this);

    }



    @OnLifecycleEvent(ON_RESUME)

    public void onResume() {

        mSubscriptionsListener.start();

        mDataEnabledListener.start(SubscriptionManager.getDefaultDataSubscriptionId());

        mConnectivityListener.start();

        update();

    }



    @OnLifecycleEvent(ON_PAUSE)

    public void onPause() {

        mSubscriptionsListener.stop();

        mDataEnabledListener.stop();

        mConnectivityListener.stop();

    }



    @Override
@@ -158,6 +173,19 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl 
        mUpdateListener.onChildrenUpdated();

    }



    private boolean activeNetworkIsCellular() {

        final Network activeNetwork = mConnectivityManager.getActiveNetwork();

        if (activeNetwork == null) {

            return false;

        }

        final NetworkCapabilities networkCapabilities = mConnectivityManager.getNetworkCapabilities(

                activeNetwork);

        if (networkCapabilities == null) {

            return false;

        }

        return networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR);

    }



    /**

     * The summary can have either 1 or 2 lines depending on which services (calls, SMS, data) this

     * subscription is the default for.
@@ -187,10 +215,10 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl 
        if (subId == dataDefaultSubId) {

            final TelephonyManager telMgrForSub = mContext.getSystemService(

                    TelephonyManager.class).createForSubscriptionId(subId);

            final int dataState = telMgrForSub.getDataState();

            if (dataState == TelephonyManager.DATA_CONNECTED) {

            boolean dataEnabled = telMgrForSub.isDataEnabled();

            if (dataEnabled && activeNetworkIsCellular()) {

                line2 = mContext.getString(R.string.mobile_data_active);

            } else if (!telMgrForSub.isDataEnabled()) {

            } else if (!dataEnabled) {

                line2 = mContext.getString(R.string.mobile_data_off);

            } else {

                line2 = mContext.getString(R.string.default_for_mobile_data);
@@ -231,6 +259,22 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl 


    @Override

    public void onSubscriptionsChanged() {

        // See if we need to change which sub id we're using to listen for enabled/disabled changes.

        int defaultDataSubId = SubscriptionManager.getDefaultDataSubscriptionId();

        if (defaultDataSubId != mDataEnabledListener.getSubId()) {

            mDataEnabledListener.stop();

            mDataEnabledListener.start(defaultDataSubId);

        }

        update();

    }



    @Override

    public void onMobileDataEnabledChange() {

        update();

    }



    @Override

    public void onDataConnectivityChange() {

        update();

    }

}

src/com/android/settings/network/telephony/DataConnectivityListener.java

0 → 100644
+73 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License

 */



package com.android.settings.network.telephony;



import android.content.Context;

import android.net.ConnectivityManager;

import android.net.Network;

import android.net.NetworkCapabilities;

import android.net.NetworkRequest;



/** A helper class to listen to a few different kinds of connectivity changes that could be relevant

 *  to changes in which network is active, and whether the active network has internet data

 *  connectivity. */

public class DataConnectivityListener extends ConnectivityManager.NetworkCallback {

    private Context mContext;

    private ConnectivityManager mConnectivityManager;

    private final NetworkRequest mNetworkRequest;

    private Client mClient;



    public interface Client {

        void onDataConnectivityChange();

    }



    public DataConnectivityListener(Context context, Client client) {

        mContext = context;

        mConnectivityManager = mContext.getSystemService(ConnectivityManager.class);

        mClient = client;

        mNetworkRequest = new NetworkRequest.Builder()

                .addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)

                .build();

    }



    public void start() {

        mConnectivityManager.registerNetworkCallback(mNetworkRequest, this,

                mContext.getMainThreadHandler());

    }



    public void stop() {

        mConnectivityManager.unregisterNetworkCallback(this);

    }



    @Override

    public void onCapabilitiesChanged(Network network, NetworkCapabilities networkCapabilities) {

        final Network activeNetwork = mConnectivityManager.getActiveNetwork();

        if (activeNetwork != null && activeNetwork.equals(network)) {

            mClient.onDataConnectivityChange();

        }

    }



    @Override

    public void onLosing(Network network, int maxMsToLive) {

        mClient.onDataConnectivityChange();

    }



    @Override

    public void onLost(Network network) {

        mClient.onDataConnectivityChange();

    }

}

tests/robotests/src/com/android/settings/network/DataConnectivityListenerTest.java

0 → 100644
+116 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License

 */



package com.android.settings.network;



import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.spy;

import static org.mockito.Mockito.verify;

import static org.mockito.Mockito.when;



import android.content.Context;

import android.net.ConnectivityManager;

import android.net.Network;

import android.net.NetworkCapabilities;

import android.net.NetworkRequest;

import android.os.Handler;



import com.android.settings.network.telephony.DataConnectivityListener;



import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.Mock;

import org.mockito.MockitoAnnotations;

import org.robolectric.RobolectricTestRunner;

import org.robolectric.RuntimeEnvironment;



@RunWith(RobolectricTestRunner.class)

public class DataConnectivityListenerTest {

    @Mock

    private DataConnectivityListener.Client mClient;

    @Mock

    private ConnectivityManager mConnectivityManager;

    @Mock

    private Network mActiveNetwork;



    private Context mContext;

    private DataConnectivityListener mListener;



    @Before

    public void setUp() {

        MockitoAnnotations.initMocks(this);

        mContext = spy(RuntimeEnvironment.application);

        when(mContext.getSystemService(ConnectivityManager.class)).thenReturn(mConnectivityManager);

        when(mConnectivityManager.getActiveNetwork()).thenReturn(mActiveNetwork);

        mListener = new DataConnectivityListener(mContext, mClient);

    }



    @Test

    public void noStart_doesNotRegister() {

        verify(mConnectivityManager, never()).registerNetworkCallback(any(NetworkRequest.class),

                any(ConnectivityManager.NetworkCallback.class), any(Handler.class));

    }



    @Test

    public void start_doesRegister() {

        mListener.start();

        verify(mConnectivityManager).registerNetworkCallback(any(NetworkRequest.class),

                eq(mListener), any(Handler.class));

    }



    @Test

    public void onCapabilitiesChanged_notActiveNetwork_noCallback() {

        Network changedNetwork = mock(Network.class);

        mListener.onCapabilitiesChanged(changedNetwork, mock(NetworkCapabilities.class));

        verify(mClient, never()).onDataConnectivityChange();

    }



    @Test

    public void onCapabilitiesChanged_activeNetwork_onDataConnectivityChangeFires() {

        mListener.onCapabilitiesChanged(mActiveNetwork, mock(NetworkCapabilities.class));

        verify(mClient).onDataConnectivityChange();

    }



    @Test

    public void onLosing_notActiveNetwork_onDataConnectivityChangeFires() {

        Network changedNetwork = mock(Network.class);

        mListener.onLosing(changedNetwork, 500);

        verify(mClient).onDataConnectivityChange();

    }



    @Test

    public void onLosing_activeNetwork_onDataConnectivityChangeFires() {

        mListener.onLosing(mActiveNetwork, 500);

        verify(mClient).onDataConnectivityChange();

    }



    @Test

    public void onLost_notActiveNetwork_onDataConnectivityChangeFires() {

        Network changedNetwork = mock(Network.class);

        mListener.onLost(changedNetwork);

        verify(mClient).onDataConnectivityChange();

    }



    @Test

    public void onLost_activeNetwork_onDataConnectivityChangeFires() {

        mListener.onLost(mActiveNetwork);

        verify(mClient).onDataConnectivityChange();

    }

}

tests/robotests/src/com/android/settings/network/MobileDataEnabledListenerTest.java

0 → 100644
+78 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License

 */



package com.android.settings.network;



import static org.mockito.Mockito.never;

import static org.mockito.Mockito.verify;



import android.content.Context;

import android.net.Uri;

import android.provider.Settings;



import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.Mock;

import org.mockito.MockitoAnnotations;

import org.robolectric.RobolectricTestRunner;

import org.robolectric.RuntimeEnvironment;



@RunWith(RobolectricTestRunner.class)

public class MobileDataEnabledListenerTest {

    private static final int SUB_ID_ONE = 111;

    private static final int SUB_ID_TWO = 222;



    @Mock

    private MobileDataEnabledListener.Client mClient;



    private Context mContext;

    private MobileDataEnabledListener mListener;



    @Before

    public void setUp() {

        MockitoAnnotations.initMocks(this);

        mContext = RuntimeEnvironment.application;

        mListener = new MobileDataEnabledListener(mContext, mClient);

    }



    @Test

    public void onMobileDataEnabledChange_firesCorrectly() {

        mListener.start(SUB_ID_ONE);

        final Uri uri = Settings.Global.getUriFor(Settings.Global.MOBILE_DATA + SUB_ID_ONE);

        mContext.getContentResolver().notifyChange(uri, null);

        verify(mClient).onMobileDataEnabledChange();

    }



    @Test

    public void onMobileDataEnabledChange_doesNotFireAfterStop() {

        mListener.start(SUB_ID_ONE);

        mListener.stop();

        final Uri uri = Settings.Global.getUriFor(Settings.Global.MOBILE_DATA + SUB_ID_ONE);

        mContext.getContentResolver().notifyChange(uri, null);

        verify(mClient, never()).onMobileDataEnabledChange();

    }



    @Test

    public void onMobileDataEnabledChange_changedToDifferentId_firesCorrectly() {

        mListener.start(SUB_ID_ONE);

        mListener.stop();

        mListener.start(SUB_ID_TWO);

        final Uri uri = Settings.Global.getUriFor(Settings.Global.MOBILE_DATA + SUB_ID_TWO);

        mContext.getContentResolver().notifyChange(uri, null);

        verify(mClient).onMobileDataEnabledChange();

    }

}