Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47ca3702 authored by Will Leshner's avatar Will Leshner
Browse files

Several screensaver picker UX improvements. 

1. Remove left/right margin from the screensaver picker grid.
2. Reduce space between icon and title for each screensaver item in the
   screensaver picker grid.

This will make the grid flush (vertically) with the other preferences on
the screen.

Bug: 415834742
Test: manually
Flag: android.service.dreams.dreams_v2
Change-Id: I0c21eb24c1f91321fbd63c89ebca80fc294e9035
parent af445713

res/layout/dream_picker_layout.xml

+2 −2
Original line number Diff line number Diff line
@@ -28,8 +28,8 @@ 
        android:layout_height="wrap_content"

        android:clipToPadding="true"

        android:nestedScrollingEnabled="false"

        android:paddingStart="?android:attr/listPreferredItemPaddingStart"

        android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

        android:paddingStart="0dp"

        android:paddingEnd="0dp"

        android:paddingBottom="@dimen/dream_preference_card_padding"

        app:layout_constraintStart_toStartOf="parent"

        app:layout_constraintEnd_toEndOf="parent"

res/values/dimens.xml

+1 −0
Original line number Diff line number Diff line
@@ -467,6 +467,7 @@ 
    <dimen name="dream_item_title_margin_bottom">8dp</dimen>

    <dimen name="dream_item_title_text_size">16sp</dimen>

    <dimen name="dream_item_icon_padding">18dp</dimen>

    <dimen name="dream_item_icon_padding_new">8dp</dimen>

    <dimen name="dream_item_title_margin_horizontal">8dp</dimen>

    <dimen name="dream_preference_card_padding">16dp</dimen>

    <dimen name="dream_preview_placeholder_width">52dp</dimen>

src/com/android/settings/dream/DreamAdapter.java

+4 −0
Original line number Diff line number Diff line
@@ -93,6 +93,10 @@ public class DreamAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> 
            if (dreamsV2()) {

                mTitleView.setEllipsize(TextUtils.TruncateAt.MARQUEE);

                mTitleView.setSingleLine();



                final int drawablePadding = mContext.getResources().getDimensionPixelSize(

                        R.dimen.dream_item_icon_padding_new);

                mTitleView.setCompoundDrawablePadding(drawablePadding);

            }



            itemView.setOnClickListener(v -> {