Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4316259a authored by Jonathan Scott's avatar Jonathan Scott
Browse files

Remove redundant (and failing) test getAvailabilityStatus_hasManagedUser_AVAILABLE 

This is already covered by
getAvailabilityStatus_somePackagesAllowed_shouldBeAvailable and
getAvailabilityStatus_allPackagesAllowed_shouldBeAvailable.

Test: make RunSettingsRoboTests -j40 ROBOTEST_FILTER=CrossProfileCalendarPreferenceControllerTest
Fixes: 130896049
Change-Id: I3dbbbde693750c69e042f7c19143730cc8e313ff
parent 33f136fd

tests/robotests/src/com/android/settings/accounts/CrossProfileCalendarPreferenceControllerTest.java

+22 −30
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ public class CrossProfileCalendarPreferenceControllerTest { 
    }



    @Test

    public void getAvailabilityStatus_noManagedUser_DISABLED() {

    public void getAvailabilityStatus_noManagedUser_shouldBeDisabled() {

        mController.setManagedUser(null);



        assertThat(mController.getAvailabilityStatus())
@@ -92,11 +92,27 @@ public class CrossProfileCalendarPreferenceControllerTest { 
    }



    @Test

    @Ignore("b/130896049")

    public void getAvailabilityStatus_hasManagedUser_AVAILABLE() {

        mController.setManagedUser(mManagedUser);

        assertThat(mController.getAvailabilityStatus())

                .isEqualTo(CrossProfileCalendarPreferenceController.AVAILABLE);

    public void getAvailabilityStatus_noPackageAllowed_shouldBeDisabledForUser() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);



        assertThat(mController.getAvailabilityStatus()).isEqualTo(DISABLED_FOR_USER);

    }



    @Test

    public void getAvailabilityStatus_somePackagesAllowed_shouldBeAvailable() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);

        dpm.setCrossProfileCalendarPackages(TEST_COMPONENT_NAME,

                Collections.singleton(TEST_PACKAGE_NAME));



        assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);

    }



    @Test

    public void getAvailabilityStatus_allPackagesAllowed_shouldBeAvailable() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);

        dpm.setCrossProfileCalendarPackages(TEST_COMPONENT_NAME, null);



        assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);

    }



    @Test
@@ -121,30 +137,6 @@ public class CrossProfileCalendarPreferenceControllerTest { 
        assertThat(mPreference.isChecked()).isTrue();

    }



    @Test

    public void getAvailabilityStatus_noPackageAllowed_shouldBeDisabledForUser() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);



        assertThat(mController.getAvailabilityStatus()).isEqualTo(DISABLED_FOR_USER);

    }



    @Test

    public void getAvailabilityStatus_somePackagesAllowed_shouldBeAvailable() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);

        dpm.setCrossProfileCalendarPackages(TEST_COMPONENT_NAME,

                Collections.singleton(TEST_PACKAGE_NAME));



        assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);

    }



    @Test

    public void getAvailabilityStatus_allPackagesAllowed_shouldBeAvailable() throws Exception {

        dpm.setProfileOwner(TEST_COMPONENT_NAME);

        dpm.setCrossProfileCalendarPackages(TEST_COMPONENT_NAME, null);



        assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);

    }



    @Test

    public void onPreferenceChangeToFalse_shouldUpdateProviderValue() {

        mController.onPreferenceChange(mPreference, false);