Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 425504c2 authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Fix blocked notifications screen 

Don't filter out apps have don't have any usage events -
the package's notifications are still blocked

Test: atest, and verify that the packages match the 'blocked
count' subtext on the previous screen on an affected device
Fixes: 158343184

Change-Id: Iac01708849e3ae0b82f97db679ce512fc9675a17
parent 21ac98e2

src/com/android/settings/applications/AppStateNotificationBridge.java

+3 −0
Original line number Diff line number Diff line
@@ -84,6 +84,9 @@ public class AppStateNotificationBridge extends AppStateBaseBridge { 
        for (AppEntry entry : apps) {

            NotificationsSentState stats =

                    map.get(getKey(UserHandle.getUserId(entry.info.uid), entry.info.packageName));

            if (stats == null) {

                stats = new NotificationsSentState();

            }

            calculateAvgSentCounts(stats);

            addBlockStatus(entry, stats);

            entry.extraInfo = stats;

tests/robotests/src/com/android/settings/applications/AppStateNotificationBridgeTest.java

+6 −1
Original line number Diff line number Diff line
@@ -211,7 +211,12 @@ public class AppStateNotificationBridgeTest { 
        when(mSession.getAllApps()).thenReturn(apps);



        mBridge.loadAllExtraInfo();

        assertThat(apps.get(0).extraInfo).isNull();

        // extra info should exist and blocked status should be populated

        assertThat(apps.get(0).extraInfo).isNotNull();

        verify(mBackend).getNotificationsBanned(PKG1, 0);

        // but the recent/frequent counts should be 0 so they don't appear on those screens

        assertThat(((NotificationsSentState) apps.get(0).extraInfo).avgSentDaily).isEqualTo(0);

        assertThat(((NotificationsSentState) apps.get(0).extraInfo).lastSent).isEqualTo(0);

    }



    @Test