Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f67f87e authored by Colin Cross's avatar Colin Cross
Browse files

Use Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY for user visible versions 

Use Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY which will show a user
friendly version name for preview releases, and the release version
for final releases.

Bug: 221950960
Test: manual
Change-Id: I3a7e6a3c996d52614b89888afd35da8cff458b43
parent 3340b8e3

src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDetailPreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ public class FirmwareVersionDetailPreferenceController extends BasePreferenceCon 


    @Override

    public CharSequence getSummary() {

        return Build.VERSION.RELEASE_OR_CODENAME;

        return Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY;

    }



    @Override

src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -34,6 +34,6 @@ public class FirmwareVersionPreferenceController extends BasePreferenceControlle 


    @Override

    public CharSequence getSummary() {

        return Build.VERSION.RELEASE_OR_CODENAME;

        return Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY;

    }

}

src/com/android/settings/deviceinfo/storage/StorageUtils.java

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ public class StorageUtils { 
        public Dialog onCreateDialog(Bundle savedInstanceState) {

            return new AlertDialog.Builder(getActivity())

                    .setMessage(getContext().getString(R.string.storage_detail_dialog_system,

                            Build.VERSION.RELEASE_OR_CODENAME))

                            Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY))

                    .setPositiveButton(android.R.string.ok, null)

                    .create();

        }

src/com/android/settings/system/SystemUpdatePreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ public class SystemUpdatePreferenceController extends BasePreferenceController { 
    @Override

    public CharSequence getSummary() {

        CharSequence summary = mContext.getString(R.string.android_version_summary,

                Build.VERSION.RELEASE_OR_CODENAME);

                Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY);

        final FutureTask<Bundle> bundleFutureTask = new FutureTask<>(

                // Put the API call in a future to avoid StrictMode violation.

                () -> mUpdateManager.retrieveSystemUpdateInfo());

tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDetailPreferenceControllerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ public class FirmwareVersionDetailPreferenceControllerTest { 


    @Test

    public void getSummary_shouldGetBuildVersion() {

        assertThat(mController.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_CODENAME);

        assertThat(mController.getSummary()).isEqualTo(Build.VERSION.RELEASE_OR_PREVIEW_DISPLAY);

    }



    @Test