Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fcd3d5f authored by Adnan's avatar Adnan Committed by Michael Bestas
Browse files

Settings: Remove "advanced mode" toggle if its defaulted to enabled. 

Change-Id: I0c0fe0bab337d0c8c6d48e20228aa26c86a2475f
parent 10a31409

res/values/config.xml

100755 → 100644
+0 −2
Original line number Diff line number Diff line
@@ -84,8 +84,6 @@ 
    <string name="ic_code" translatable="false"></string>

    <string name="ic_model" translatable="false"></string>



    <bool name="config_default_advanced_mode_enabled">false</bool>



    <!-- This is use to determine whether to hide the performance settings-->

    <bool name="config_hidePerformanceSettings" translatable="false">false</bool>

src/com/android/settings/DeviceInfoSettings.java

+7 −3
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment implements In 


        // Read platform settings for additional system update setting

        removePreferenceIfBoolFalse(KEY_UPDATE_SETTING,

                R.bool.config_additional_system_update_setting_enable);

                getResources().getBoolean(R.bool.config_additional_system_update_setting_enable));



        // Remove regulatory information if none present.

        final Intent intent = new Intent(Settings.ACTION_SHOW_REGULATORY_INFO);
@@ -201,7 +201,11 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment implements In 
                getPreferenceScreen().removePreference(pref);

            }

        }



        mAdvancedSettings = (SecureSettingSwitchPreference) findPreference(KEY_ADVANCED_MODE);

        // If enabled by default, just remove the setting, because it's confusing.

        removePreferenceIfBoolFalse(KEY_ADVANCED_MODE, !getResources().getBoolean(

                com.android.internal.R.bool.config_advancedSettingsMode));

    }



    @Override
@@ -304,8 +308,8 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment implements In 
        }

    }



    private void removePreferenceIfBoolFalse(String preference, int resId) {

        if (!getResources().getBoolean(resId)) {

    private void removePreferenceIfBoolFalse(String preference, boolean bool) {

        if (!bool) {

            Preference pref = findPreference(preference);

            if (pref != null) {

                getPreferenceScreen().removePreference(pref);

src/com/android/settings/SettingsActivity.java

+9 −5
Original line number Diff line number Diff line
@@ -1437,11 +1437,15 @@ public class SettingsActivity extends Activity 
        super.onNewIntent(intent);

    }



    /**

     * Showing "advanced options" on a retail build involves a toggle,

     * however, it should always show all advanced options if the option is enabled

     * by default in an overlay.

     */

    public static boolean showAdvancedPreferences(Context context) {

        return android.provider.Settings.Secure.getInt(

                context.getContentResolver(),

                android.provider.Settings.Secure.ADVANCED_MODE, 1) == 1;

        return (android.provider.Settings.Secure.getInt(context.getContentResolver(),

                android.provider.Settings.Secure.ADVANCED_MODE, 1) == 1)

                && context.getResources().getBoolean(

                com.android.internal.R.bool.config_advancedSettingsMode);

    }





}