Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a91abd1 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Fix failing checkcolor_hook in Settings" into udc-dev am: cebb5582 

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21850207



Change-Id: I9109c7ad1fe9d89fe13b5b573ec4f6d429909172
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 2fe33aa7 cebb5582

color-check-baseline.xml

+16 −0
Original line number Diff line number Diff line
@@ -4477,6 +4477,22 @@ 
            column="13"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="            android:tint=&quot;#4F8438&quot;"

        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/layout/locale_dialog.xml"

            line="36"

            column="13"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"