Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2545b4aa authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Hide header if no items present

Test: atest
Fixes: 157093918
Change-Id: If4f86ff71fc5e961e36e5485186d247546355174
parent 73b6bfc1
Loading
Loading
Loading
Loading
+17 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ import android.view.View;
import android.widget.ImageView;

import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceViewHolder;

import com.android.settings.R;
@@ -54,6 +55,13 @@ public class AppBubbleListPreferenceController extends AppConversationListPrefer
        super(context, backend);
    }

    @Override
    public void updateState(Preference preference) {
        // loading convos is async; hide header until we know we have conversations to show
        preference.setVisible(false);
        super.updateState(preference);
    }

    @Override
    public void onResume(NotificationBackend.AppRow appRow,
            @Nullable NotificationChannel channel, @Nullable NotificationChannelGroup group,
@@ -134,6 +142,15 @@ public class AppBubbleListPreferenceController extends AppConversationListPrefer
        return pref;
    }

    @Override
    protected void populateList() {
        super.populateList();
        if (mPreference == null) {
            return;
        }
        mPreference.setVisible(mPreference.getPreferenceCount() > 0);
    }

    /** Simple preference with a 'x' button at the end. */
    @VisibleForTesting
    public static class ConversationPreference extends Preference implements View.OnClickListener {
+1 −1
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ public class AppConversationListPreferenceController extends NotificationPrefere
        return R.string.conversations_category_title;
    }

    private void populateList() {
    protected void populateList() {
        if (mPreference == null) {
            return;
        }