Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2491d639 authored by Soonil Nagarkar's avatar Soonil Nagarkar
Browse files

Remove dynamic location settings footer

Replace with static location settings footer.

Bug: 182210346
Test: manual
Change-Id: If3ab492418e5f3461f7b0123fc771ecdd56db6c9
parent d8c9a539
Loading
Loading
Loading
Loading
+5 −0
Original line number Diff line number Diff line
@@ -684,6 +684,11 @@
    </plurals>
    <!-- Location settings, loading the number of apps which have location permission [CHAR LIMIT=30] -->
    <string name="location_settings_loading_app_permission_stats">Loading\u2026</string>
    <!-- Location settings footer warning text [CHAR LIMIT=NONE] -->
    <string name="location_settings_footer">
        Location may use sources like GPS, Wi\u2011Fi, mobile networks, and sensors to help estimate
        your device\u2019s location.
    </string>
    <!-- Main Settings screen setting option title for the item to take you to the accounts screen [CHAR LIMIT=22] -->
    <string name="account_settings_title">Accounts</string>
+3 −4
Original line number Diff line number Diff line
@@ -76,9 +76,8 @@

    </PreferenceCategory>

    <PreferenceCategory
    <com.android.settingslib.widget.FooterPreference
        android:title="@string/location_settings_footer"
        android:key="location_footer"
        android:layout="@layout/preference_category_no_label"
        settings:allowDividerAbove="false"
        settings:controller="com.android.settings.location.LocationFooterPreferenceController"/>
        android:selectable="false"/>
</PreferenceScreen>
+3 −4
Original line number Diff line number Diff line
@@ -53,9 +53,8 @@
        android:fragment="com.android.settings.location.LocationServices"
        settings:controller="com.android.settings.location.LocationServicesPreferenceController"/>

    <PreferenceCategory
    <com.android.settingslib.widget.FooterPreference
        android:title="@string/location_settings_footer"
        android:key="location_footer"
        android:layout="@layout/preference_category_no_label"
        settings:allowDividerAbove="false"
        settings:controller="com.android.settings.location.LocationFooterPreferenceController"/>
        android:selectable="false"/>
</PreferenceScreen>
+3 −4
Original line number Diff line number Diff line
@@ -61,9 +61,8 @@
        android:fragment="com.android.settings.location.LocationServicesForWork"
        settings:controller="com.android.settings.location.LocationServicesForWorkPreferenceController"/>

    <PreferenceCategory
    <com.android.settingslib.widget.FooterPreference
        android:title="@string/location_settings_footer"
        android:key="location_footer"
        android:layout="@layout/preference_category_no_label"
        settings:allowDividerAbove="false"
        settings:controller="com.android.settings.location.LocationFooterPreferenceController"/>
        android:selectable="false"/>
</PreferenceScreen>
+0 −162
Original line number Diff line number Diff line
/*
 * Copyright (C) 2018 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
 * except in compliance with the License. You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software distributed under the
 * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied. See the License for the specific language governing
 * permissions and limitations under the License.
 */
package com.android.settings.location;

import android.content.Context;
import android.content.Intent;
import android.content.pm.ActivityInfo;
import android.content.pm.ApplicationInfo;
import android.content.pm.PackageManager;
import android.content.pm.PackageManager.NameNotFoundException;
import android.content.pm.ResolveInfo;
import android.location.LocationManager;
import android.util.Log;

import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;

import com.android.settingslib.widget.FooterPreference;

import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.List;

/**
 * Preference controller for location footer preference category
 */
public class LocationFooterPreferenceController extends LocationBasePreferenceController {

    private static final String TAG = "LocationFooter";
    private static final Intent INJECT_INTENT =
            new Intent(LocationManager.SETTINGS_FOOTER_DISPLAYED_ACTION);

    private final PackageManager mPackageManager;

    public LocationFooterPreferenceController(Context context, String key) {
        super(context, key);
        mPackageManager = context.getPackageManager();
    }

    /**
     * Insert footer preferences.
     */
    @Override
    public void updateState(Preference preference) {
        PreferenceCategory category = (PreferenceCategory) preference;
        category.removeAll();
        Collection<FooterData> footerData = getFooterData();
        for (FooterData data : footerData) {
            try {
                String footerString =
                        mPackageManager
                                .getResourcesForApplication(data.applicationInfo)
                                .getString(data.footerStringRes);

                // Generate a footer preference with the given text
                FooterPreference footerPreference = new FooterPreference(preference.getContext());
                footerPreference.setTitle(footerString);
                category.addPreference(footerPreference);
            } catch (NameNotFoundException exception) {
                Log.w(
                        TAG,
                        "Resources not found for application "
                                + data.applicationInfo.packageName);
            }
        }
    }

    /**
     * Do nothing on location mode changes.
     */
    @Override
    public void onLocationModeChanged(int mode, boolean restricted) {}

    /**
     * Location footer preference group should be displayed if there is at least one footer to
     * inject.
     */
    @Override
    public int getAvailabilityStatus() {
        return !getFooterData().isEmpty() ? AVAILABLE : UNSUPPORTED_ON_DEVICE;
    }

    /**
     * Return a list of strings with text provided by ACTION_INJECT_FOOTER broadcast receivers.
     */
    private List<FooterData> getFooterData() {
        // Fetch footer text from system apps
        List<ResolveInfo> resolveInfos =
                mPackageManager.queryBroadcastReceivers(
                        INJECT_INTENT, PackageManager.GET_META_DATA);
        if (resolveInfos == null) {
            Log.e(TAG, "Unable to resolve intent " + INJECT_INTENT);
            return Collections.emptyList();
        }

        if (Log.isLoggable(TAG, Log.DEBUG)) {
            Log.d(TAG, "Found broadcast receivers: " + resolveInfos);
        }

        List<FooterData> footerDataList = new ArrayList<>(resolveInfos.size());
        for (ResolveInfo resolveInfo : resolveInfos) {
            ActivityInfo activityInfo = resolveInfo.activityInfo;
            ApplicationInfo appInfo = activityInfo.applicationInfo;

            // If a non-system app tries to inject footer, ignore it
            if ((appInfo.flags & ApplicationInfo.FLAG_SYSTEM) == 0) {
                Log.w(TAG, "Ignoring attempt to inject footer from app not in system image: "
                        + resolveInfo);
                continue;
            }

            // Get the footer text resource id from broadcast receiver's metadata
            if (activityInfo.metaData == null) {
                if (Log.isLoggable(TAG, Log.DEBUG)) {
                    Log.d(TAG, "No METADATA in broadcast receiver " + activityInfo.name);
                }
                continue;
            }

            final int footerTextRes =
                    activityInfo.metaData.getInt(LocationManager.METADATA_SETTINGS_FOOTER_STRING);
            if (footerTextRes == 0) {
                Log.w(
                        TAG,
                        "No mapping of integer exists for "
                                + LocationManager.METADATA_SETTINGS_FOOTER_STRING);
                continue;
            }
            footerDataList.add(new FooterData(footerTextRes, appInfo));
        }
        return footerDataList;
    }

    /**
     * Contains information related to a footer.
     */
    private static class FooterData {

        // The string resource of the footer
        final int footerStringRes;

        // Application info of receiver injecting this footer
        final ApplicationInfo applicationInfo;

        FooterData(int footerRes, ApplicationInfo appInfo) {
            this.footerStringRes = footerRes;
            this.applicationInfo = appInfo;
        }
    }
}
Loading