Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23c16975 authored by Roman Birg's avatar Roman Birg Committed by Gerrit Code Review
Browse files

Settings: improve job upload service 



We should be removing the job even if the job failed.

Change-Id: I7468af9a972fd88c5ed2a93ad5781637407e3a85
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>
parent 6ec80c98

src/com/android/settings/cmstats/StatsUploadJobService.java

+8 −9
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ public class StatsUploadJobService extends JobService { 
        return false;

    }



    private class StatsUploadTask extends AsyncTask<Void, Void, Void> {

    private class StatsUploadTask extends AsyncTask<Void, Void, Boolean> {



        private JobParameters mJobParams;
@@ -97,7 +97,7 @@ public class StatsUploadJobService extends JobService { 
        }



        @Override

        protected Void doInBackground(Void... params) {

        protected Boolean doInBackground(Void... params) {



            PersistableBundle extras = mJobParams.getExtras();
@@ -144,17 +144,16 @@ public class StatsUploadJobService extends JobService { 
                        break;

                }

            }



            if (success) {

                // we hit the server, succeed either which way.

                mCurrentJobs.remove(mJobParams);

            }



            if (DEBUG)

                Log.d(TAG, "job id " + mJobParams.getJobId() + ", has finished with success="

                        + success);

            return success;

        }



        @Override

        protected void onPostExecute(Boolean success) {

            mCurrentJobs.remove(mJobParams);

            jobFinished(mJobParams, !success);

            return null;

        }

    }