Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ef4caaf authored by Colin Cross's avatar Colin Cross
Browse files

Fix errorprone build 

Fixes:
packages/apps/Settings/tests/robotests/src/com/android/settings/language/LanguageAndInputSettingsTest.java:95: error: [MockitoCast] A bug in Mockito will cause this test to fail at runtime with a ClassCastException
        when(mContext.getSystemService(AutofillManager.class)).thenReturn(mAutofillManager);
            ^
    (see http://errorprone.info/bugpattern/MockitoCast)
  Did you mean 'when((Object) mContext.getSystemService(AutofillManager.class)).thenReturn(mAutofillManager);'?

packages/apps/Settings/tests/robotests/src/com/android/settings/search/IntentSearchViewHolderTest.java:195: error: [JUnit4TestNotRun] Test method will not be run; please add @Test annotation
    public void testBindViewElements_appSearchResult() {
                ^
    (see http://errorprone.info/bugpattern/JUnit4TestNotRun)
  Did you mean '@Test'?

Bug: 64489631
Test: m -j RUN_ERROR_PRONE=true javac-check
Merged-In: I79477f331ae447d2505a1519da09886bf07ba1a2
Merged-in: I333372699b263d02cc4083289dc746c7aacd414d
Change-Id: I8fd30fc741927de3f6527aca6d98d8851ef23794
parent 54eeafa0

tests/robotests/src/com/android/settings/language/LanguageAndInputSettingsTest.java

+2 −1
Original line number Diff line number Diff line
@@ -92,7 +92,8 @@ public class LanguageAndInputSettingsTest { 
                .thenReturn(mock(TextServicesManager.class));

        when(mContext.getSystemService(Context.DEVICE_POLICY_SERVICE)).thenReturn(mDpm);

        when(mContext.getSystemService(Context.INPUT_METHOD_SERVICE)).thenReturn(mImm);

        when(mContext.getSystemService(AutofillManager.class)).thenReturn(mAutofillManager);

        when((Object) mContext.getSystemService(AutofillManager.class))

                .thenReturn(mAutofillManager);

        mFragment = new TestFragment(mContext);

    }

tests/robotests/src/com/android/settings/search/IntentSearchViewHolderTest.java

+3 −0
Original line number Diff line number Diff line
@@ -50,6 +50,7 @@ import com.android.settings.search2.SearchResult.Builder; 
import com.android.settings.testutils.FakeFeatureFactory;



import org.junit.Before;

import org.junit.Ignore;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.Answers;
@@ -192,6 +193,8 @@ public class IntentSearchViewHolderTest { 
        assertThat(mHolder.summaryView.getVisibility()).isEqualTo(View.GONE);

    }



    @Test

    @Ignore

    public void testBindViewElements_appSearchResult() {

        when(mPackageManager.getUserBadgedLabel(any(CharSequence.class),

                eq(new UserHandle(USER_ID)))).thenReturn(BADGED_LABEL);