Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 194abe94 authored by Salvador Martinez's avatar Salvador Martinez
Browse files

Update dark mode in accessiblity settings 

There was an entry point to dark mode that wasn't updated when the
display settings one was changed to point to a new screen. This
change makes it so that clicking dark mode in accessiblity also
opens the same screen.

Test: robotests pass
Bug: 129406772
Change-Id: I0ad830638e04e5520cdf7de6927764fa6b68a179
parent 12256ca4

res/xml/accessibility_settings.xml

+2 −4
Original line number Diff line number Diff line
@@ -58,12 +58,10 @@ 
            android:title="@string/screen_zoom_title"

            settings:searchable="false"/>



        <ListPreference

        <Preference

            android:key="dark_ui_mode_accessibility"

            android:fragment="com.android.settings.display.DarkUISettings"

            android:title="@string/dark_ui_mode"

            android:dialogTitle="@string/dark_ui_mode_title"

            android:entries="@array/dark_ui_mode_entries"

            android:entryValues="@array/dark_ui_mode_values"

            settings:searchable="false" />



        <Preference

src/com/android/settings/accessibility/AccessibilitySettings.java

+1 −1
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ public class AccessibilitySettings extends SettingsPreferenceFragment implements 
    private SwitchPreference mToggleInversionPreference;

    private ColorInversionPreferenceController mInversionPreferenceController;

    private AccessibilityHearingAidPreferenceController mHearingAidPreferenceController;

    private ListPreference mDarkUIModePreference;

    private Preference mDarkUIModePreference;

    private DarkUIPreferenceController mDarkUIPreferenceController;



    private int mLongPressTimeoutDefault;

tests/robotests/src/com/android/settings/accessibility/AccessibilitySettingsTest.java

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ public class AccessibilitySettingsTest { 


    @Test

    public void testDarkUIModePreferenceSummary_shouldUpdateSummary() {

        final ListPreference darkUIModePreference = new ListPreference(mContext);

        final Preference darkUIModePreference = new Preference(mContext);

        final DarkUIPreferenceController mController;

        doReturn(darkUIModePreference).when(mSettings).findPreference(

            DARK_UI_MODE_PREFERENCE);