Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18aa329d authored by Shen Lin's avatar Shen Lin
Browse files

Fix incorrect switch status when user stay in NightDisplaySettings page while... 

Fix incorrect switch status when user stay in NightDisplaySettings page while scheduled night lights on

The main reason for this problem is that someone forgot to super's updateState() to update the ui, so the internal status was updated but ui status was not. For now since updateStateInternal() did nothing substantive, it is suggested to remove this override to fix.

Bug: b/241957450 b/255902043
Test: manually tap button according to bug report.
Change-Id: I80d1173986a9f22c4a77c8c13011292c08f8dc2e
parent fdbd2d10

src/com/android/settings/display/NightDisplayActivationPreferenceController.java

+0 −15
Original line number Diff line number Diff line
@@ -90,11 +90,6 @@ public class NightDisplayActivationPreferenceController extends 
        }

    }



    @Override

    public final void updateState(Preference preference) {

        updateStateInternal();

    }



    /** FOR SLICES */



    @Override
@@ -112,14 +107,4 @@ public class NightDisplayActivationPreferenceController extends 
        return mTimeFormatter.getAutoModeSummary(mContext, mColorDisplayManager);

    }



    private void updateStateInternal() {

        final boolean isActivated = mColorDisplayManager.isNightDisplayActivated();

        final int autoMode = mColorDisplayManager.getNightDisplayAutoMode();



        if (autoMode == ColorDisplayManager.AUTO_MODE_CUSTOM_TIME) {

            mTimeFormatter.getFormattedTimeString(isActivated

                    ? mColorDisplayManager.getNightDisplayCustomStartTime()

                    : mColorDisplayManager.getNightDisplayCustomEndTime());

        }

    }

}