Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 159b8aed authored by Eghosa Ewansiha-Vlachavas's avatar Eghosa Ewansiha-Vlachavas
Browse files

Update aspect ratio summary strings 

Replace usage of `aspect_ratio_summary` and `aspect_ratio_main_summary`
with `aspect_ratio_summary_text` and `aspect_ratio_main_summary_text`

Fixes: 302142203
Test: Manual
Change-Id: Id7570269806e2dd15f45bdc0aad1ed0534e259b6
parent 734aae86

src/com/android/settings/applications/appcompat/UserAspectRatioAppsPreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -43,6 +43,6 @@ public class UserAspectRatioAppsPreferenceController extends BasePreferenceContr 


    @Override

    public CharSequence getSummary() {

        return mContext.getResources().getString(R.string.aspect_ratio_summary, Build.MODEL);

        return mContext.getResources().getString(R.string.aspect_ratio_summary_text, Build.MODEL);

    }

}

src/com/android/settings/spa/app/appcompat/UserAspectRatioAppsPageProvider.kt

+2 −2
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ object UserAspectRatioAppsPageProvider : SettingsPageProvider { 


    @Composable

    @VisibleForTesting

    fun getSummary(): String = stringResource(R.string.aspect_ratio_summary, Build.MODEL)

    fun getSummary(): String = stringResource(R.string.aspect_ratio_summary_text, Build.MODEL)

}



@Composable
@@ -110,7 +110,7 @@ fun UserAspectRatioAppList( 
        appList = appList,

        header = {

            Box(Modifier.padding(SettingsDimension.itemPadding)) {

                SettingsBody(stringResource(R.string.aspect_ratio_main_summary, Build.MODEL))

                SettingsBody(stringResource(R.string.aspect_ratio_main_summary_text, Build.MODEL))

            }

            Illustration(object : IllustrationModel {

                override val resId = R.raw.user_aspect_ratio_education

tests/spa_unit/src/com/android/settings/spa/app/appcompat/UserAspectRatioAppsPageProviderTest.kt

+1 −1
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ class UserAspectRatioAppsPageProviderTest { 
    fun injectEntry_summary() {

        setInjectEntry()

        composeTestRule

            .onNodeWithText(context.getString(R.string.aspect_ratio_summary, Build.MODEL))

            .onNodeWithText(context.getString(R.string.aspect_ratio_summary_text, Build.MODEL))

            .assertIsDisplayed()

    }