Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 133c73f5 authored by Edgar Wang's avatar Edgar Wang
Browse files

Update icon color for "Accessibility" and "Support & Tips" for Dark mode 

Change-Id: I874354f3eb669b36822a3fac7e9160ac19d65d35
Fixes: 119785748
Test: robotests & visual
parent d949f7d0

color-check-baseline.xml

+70 −6
Original line number Diff line number Diff line
@@ -161,6 +161,22 @@ 
            column="5"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="  &lt;color name=&quot;homepage_accessibility_background&quot;>#783BE5&lt;/color>"

        errorLine2="  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/values-night/colors.xml"

            line="22"

            column="3"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"
@@ -177,6 +193,22 @@ 
            column="5"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="  &lt;color name=&quot;homepage_support_background&quot;>#3F5FBD&lt;/color>"

        errorLine2="  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/values-night/colors.xml"

            line="23"

            column="3"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"
@@ -1145,7 +1177,7 @@ 
        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="    &lt;color name=&quot;homepage_accessibility_background&quot;>#783BE5&lt;/color>"

        errorLine1="    &lt;color name=&quot;homepage_accessibility_background&quot;>#5011C1&lt;/color>"

        errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/values/colors.xml"
@@ -1177,7 +1209,7 @@ 
        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="    &lt;color name=&quot;homepage_support_background&quot;>#3F5FBD&lt;/color>"

        errorLine1="    &lt;color name=&quot;homepage_support_background&quot;>#26459C&lt;/color>"

        errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/values/colors.xml"
@@ -1777,6 +1809,22 @@ 
            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="                android:color=&quot;@color/homepage_accessibility_background&quot; />"

        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/drawable/ic_homepage_accessibility.xml"

            line="23"

            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"
@@ -1985,6 +2033,22 @@ 
            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="                android:color=&quot;@color/homepage_support_background&quot; />"

        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/drawable/ic_homepage_support.xml"

            line="23"

            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"
@@ -2605,7 +2669,7 @@ 
        errorLine2="                                   ~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/values/strings.xml"

            line="5806"

            line="5907"

            column="36"/>

    </issue>
@@ -2637,7 +2701,7 @@ 
        errorLine2="                                           ^">

        <location

            file="res/values/styles.xml"

            line="419"

            line="427"

            column="44"/>

    </issue>
@@ -2653,7 +2717,7 @@ 
        errorLine2="                                           ^">

        <location

            file="res/values/styles.xml"

            line="425"

            line="433"

            column="44"/>

    </issue>
@@ -2669,7 +2733,7 @@ 
        errorLine2="                                           ^">

        <location

            file="res/values/styles.xml"

            line="426"

            line="434"

            column="44"/>

    </issue>

res/values-night/colors.xml

+2 −0
Original line number Diff line number Diff line
@@ -19,5 +19,7 @@ 
  <color name="switch_bar_background">#dadce0</color>

  <color name="switchbar_switch_track_tint">#82000000</color>

  <color name="switchbar_switch_thumb_tint">@android:color/black</color>

  <color name="homepage_accessibility_background">#783BE5</color>

  <color name="homepage_support_background">#3F5FBD</color>

</resources>

res/values/colors.xml

+2 −2
Original line number Diff line number Diff line
@@ -116,9 +116,9 @@ 
    <color name="homepage_storage_background">#C14CE6</color>

    <color name="homepage_security_background">#0F9D58</color>

    <color name="homepage_accounts_background">#F15B8D</color>

    <color name="homepage_accessibility_background">#783BE5</color>

    <color name="homepage_accessibility_background">#5011C1</color>

    <color name="homepage_system_background">#9E9E9E</color>

    <color name="homepage_support_background">#3F5FBD</color>

    <color name="homepage_support_background">#26459C</color>

    <color name="homepage_generic_icon_background">#1A73E8</color>

    <color name="homepage_location_background">#2EC7DC</color>

    <color name="homepage_about_background">#9FA8DA</color>