Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 104e4120 authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Fix empty icon while tapping Auto-rotate screen widget" into udc-dev

parents c89b8e6d 75a1a3f6
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1358,7 +1358,7 @@
        <activity
            android:name="Settings$SmartAutoRotateSettingsActivity"
            android:label="@string/accelerometer_title"
            android:icon="@drawable/ic_screen_rotation_24dp"
            android:icon="@drawable/ic_screen_rotation"
            android:exported="true">
            <intent-filter android:priority="1">
                <action android:name="android.settings.AUTO_ROTATE_SETTINGS" />
+16 −0
Original line number Diff line number Diff line
@@ -4429,6 +4429,22 @@
            column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="            android:color=&quot;@color/homepage_display_background&quot; />"
        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/drawable/ic_screen_rotation.xml"
            line="24"
            column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
+33 −0
Original line number Diff line number Diff line
<?xml version="1.0" encoding="utf-8"?>
<!--
  Copyright (C) 2023 The Android Open Source Project

  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
  -->

<layer-list xmlns:android="http://schemas.android.com/apk/res/android">

    <item>
        <com.android.settingslib.widget.AdaptiveIconShapeDrawable
            android:width="@dimen/dashboard_tile_image_size"
            android:height="@dimen/dashboard_tile_image_size"
            android:color="@color/homepage_display_background" />
    </item>

    <item
        android:width="@dimen/dashboard_tile_foreground_image_size"
        android:height="@dimen/dashboard_tile_foreground_image_size"
        android:start="@dimen/dashboard_tile_foreground_image_inset"
        android:top="@dimen/dashboard_tile_foreground_image_inset"
        android:drawable="@drawable/ic_screen_rotation_24dp" />
</layer-list>