Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ff942e5 authored by Andrew Sapperstein's avatar Andrew Sapperstein
Browse files

Delete unused layout: preference_importance_slider. 

And its associated colors.

Test: builds
Change-Id: Ibe3f4399b15d97f976a598553b04d92296067a74
parent 7d8e770b

color-check-baseline.xml

+0 −32
Original line number Diff line number Diff line
@@ -2113,38 +2113,6 @@ 
            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="                android:background=&quot;#00ffffff&quot;"

        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/layout/preference_importance_slider.xml"

            line="59"

            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

        message="Avoid using hardcoded color"

        category="Correctness"

        priority="4"

        summary="Using hardcoded color"

        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."

        errorLine1="                android:progressBackgroundTint=&quot;@color/importance_secondary_slider_color&quot;"

        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">

        <location

            file="res/layout/preference_importance_slider.xml"

            line="60"

            column="17"/>

    </issue>



    <issue

        id="HardCodedColor"

        severity="Error"

res/layout/preference_importance_slider.xml

deleted100644 → 0
+0 −78
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!-- Copyright (C) 2015 The Android Open Source Project



     Licensed under the Apache License, Version 2.0 (the "License");

     you may not use this file except in compliance with the License.

     You may obtain a copy of the License at



          http://www.apache.org/licenses/LICENSE-2.0



     Unless required by applicable law or agreed to in writing, software

     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

     See the License for the specific language governing permissions and

     limitations under the License.

-->



<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

              android:layout_width="match_parent"

              android:layout_height="wrap_content"

              android:minHeight="?android:attr/listPreferredItemHeight"

              android:gravity="center_vertical"

              android:paddingStart="?android:attr/listPreferredItemPaddingStart"

              android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

              android:paddingTop="8dp"

              android:paddingBottom="8dp"

              android:orientation="vertical"

              android:clickable="false"

              android:focusable="false" >



    <TextView

            android:id="@android:id/title"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:singleLine="true"

            android:textAppearance="@android:style/TextAppearance.Material.Subhead"

            android:textColor="?android:attr/textColorPrimary"

            android:ellipsize="marquee"

            android:fadingEdge="horizontal" />



    <FrameLayout

            android:layout_width="match_parent"

            android:layout_height="wrap_content" >



        <ImageView

                android:id="@+id/auto_importance"

                android:src="@drawable/notification_auto_importance"

                android:layout_gravity="center_vertical|start"

                android:layout_width="48dp"

                android:layout_height="48dp" />



        <SeekBar

                android:id="@*android:id/seekbar"

                android:layout_marginStart="56dp"

                android:layout_marginEnd="32dp"

                android:layout_gravity="center_vertical"

                android:layout_width="match_parent"

                android:layout_height="48dp"

                android:focusable="true"

                android:background="#00ffffff"

                android:progressBackgroundTint="@color/importance_secondary_slider_color"

                android:thumbTint="?android:attr/colorAccent"

                android:progressTint="?android:attr/colorAccent"

                style="@android:style/Widget.Material.SeekBar.Discrete"

                android:tickMarkTint="@android:color/black" />



    </FrameLayout>



    <TextView

            android:id="@android:id/summary"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_alignStart="@android:id/title"

            android:textAlignment="viewStart"

            android:textAppearance="@android:style/TextAppearance.Material.Body1"

            android:textColor="?android:attr/textColorSecondary"

            android:maxLines="10"

            android:minLines="3" />

</LinearLayout>

res/values/colors.xml

+0 −3
Original line number Diff line number Diff line
@@ -94,9 +94,6 @@ 
    <color name="message_icon_background_outgoing">#4285f4</color>

    <color name="message_icon_text_outgoing">#ffffffff</color>



    <color name="importance_disabled_slider_color">@*android:color/material_grey_300</color>

    <color name="importance_secondary_slider_color">#858383</color>



    <color name="usage_graph_dots">#B0BEC5</color>



    <!-- Gestures settings -->