Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fdf78cf authored by Stanley Wang's avatar Stanley Wang
Browse files

Hardware version should should support copy action 

Implement isSliceable method in HardwareRevisionPreferenceController

Fixes: 130653205
Test: manual and robotests
Change-Id: Ib872b9625c2c1984ff7b036fef5b3145c7fd8d2a
parent 7cc1469b

src/com/android/settings/deviceinfo/hardwareinfo/HardwareRevisionPreferenceController.java

+12 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ import android.os.SystemProperties; 


import com.android.settings.R;

import com.android.settings.core.BasePreferenceController;

import com.android.settings.slices.Sliceable;



public class HardwareRevisionPreferenceController extends BasePreferenceController {
@@ -44,6 +45,17 @@ public class HardwareRevisionPreferenceController extends BasePreferenceControll 
        return true;

    }



    @Override

    public boolean isCopyableSlice() {

        return true;

    }



    @Override

    public void copy() {

        Sliceable.setCopyContent(mContext, getSummary(),

                mContext.getText(R.string.hardware_revision));

    }



    @Override

    public CharSequence getSummary() {

        return SystemProperties.get("ro.boot.hardware.revision");

tests/robotests/src/com/android/settings/deviceinfo/hardwareinfo/HardwareRevisionPreferenceControllerTest.java

0 → 100644
+71 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License

 */



package com.android.settings.deviceinfo.hardwareinfo;



import static android.content.Context.CLIPBOARD_SERVICE;



import static com.google.common.truth.Truth.assertThat;



import android.content.ClipboardManager;

import android.content.Context;

import android.os.SystemProperties;



import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.MockitoAnnotations;

import org.robolectric.RobolectricTestRunner;

import org.robolectric.RuntimeEnvironment;



@RunWith(RobolectricTestRunner.class)

public class HardwareRevisionPreferenceControllerTest {



    private Context mContext;

    private HardwareRevisionPreferenceController mController;



    @Before

    public void setUp() {

        MockitoAnnotations.initMocks(this);

        mContext = RuntimeEnvironment.application;

        mController = new HardwareRevisionPreferenceController(mContext,

                "hardware_info_device_revision");

    }



    @Test

    public void isSliceable_shouldBeSliceable() {

        assertThat(mController.isSliceable()).isTrue();

    }



    @Test

    public void isCopyableSlice_shouldBeCopyableSlice() {

        assertThat(mController.isCopyableSlice()).isTrue();

    }



    @Test

    public void copy_shouldCopyHardwareRevisionToClipboard() {

        final String fakeHardwareVer = "FakeVer1.0";

        SystemProperties.set("ro.boot.hardware.revision", fakeHardwareVer);



        mController.copy();



        final ClipboardManager clipboard = (ClipboardManager) mContext.getSystemService(

                CLIPBOARD_SERVICE);

        final CharSequence data = clipboard.getPrimaryClip().getItemAt(0).getText();



        assertThat(data.toString()).isEqualTo(fakeHardwareVer);

    }

}
 
 No newline at end of file