Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c605c80 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Move non-theme styles to styles.xml"

parents 20f85d2a a122be1c
Loading
Loading
Loading
Loading
+1 −4
Original line number Diff line number Diff line
@@ -1923,7 +1923,7 @@
        <activity android:name=".bluetooth.RequestPermissionActivity"
                  android:excludeFromRecents="true"
                  android:permission="android.permission.BLUETOOTH"
                  android:theme="@style/BluetoothPermission">
                  android:theme="@style/Theme.BluetoothPermission">
            <intent-filter android:priority="1">
                <action android:name="android.bluetooth.adapter.action.REQUEST_DISCOVERABLE" />
                <action android:name="android.bluetooth.adapter.action.REQUEST_ENABLE" />
@@ -2520,9 +2520,6 @@
                <action android:name="android.settings.ALL_APPS_NOTIFICATION_SETTINGS" />
                <category android:name="android.intent.category.DEFAULT" />
            </intent-filter>
            <intent-filter android:priority="150">
                <action android:name="com.android.settings.action.SETTINGS" />
            </intent-filter>
            <meta-data android:name="com.android.settings.FRAGMENT_CLASS"
                       android:value="com.android.settings.applications.manageapplications.ManageApplications" />
        </activity>
+83 −195
Original line number Diff line number Diff line
@@ -1345,22 +1345,6 @@
            column="8"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="                android:textColor=&quot;@color/red&quot;"
        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/credentials_dialog.xml"
            line="36"
            column="17"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
@@ -2113,102 +2097,6 @@
            column="15"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="                android:textColor=&quot;#ffffb060&quot;"
        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/permission_settings.xml"
            line="46"
            column="17"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="            android:background=&quot;#000000&quot; />"
        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/radio_info.xml"
            line="116"
            column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="            android:background=&quot;#000000&quot; />"
        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/radio_info.xml"
            line="135"
            column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="            android:background=&quot;#000000&quot; />"
        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/radio_info.xml"
            line="165"
            column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="            android:background=&quot;#000000&quot; />"
        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/layout/radio_info.xml"
            line="303"
            column="13"/>
    </issue>

    <issue
            id="HardCodedColor"
            severity="Error"
            message="Avoid using hardcoded color"
            category="Correctness"
            priority="4"
            summary="Using hardcoded color"
            explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
            errorLine1="            android:background=&quot;#000000&quot; />"
            errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
                file="res/layout/radio_info.xml"
                line="303"
                column="13"/>
    </issue>

    <issue
        id="HardCodedColor"
        severity="Error"
@@ -2445,7 +2333,7 @@
        errorLine2="                                                                                                                                                                       ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values-en-rXC/strings.xml"
            line="2531"
            line="2559"
            column="168"/>
    </issue>

@@ -2461,7 +2349,7 @@
        errorLine2="                                                               ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values-en-rAU/strings.xml"
            line="2532"
            line="2560"
            column="64"/>
    </issue>

@@ -2477,7 +2365,7 @@
        errorLine2="                                                               ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values-en-rCA/strings.xml"
            line="2532"
            line="2560"
            column="64"/>
    </issue>

@@ -2493,7 +2381,7 @@
        errorLine2="                                                               ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values-en-rGB/strings.xml"
            line="2532"
            line="2560"
            column="64"/>
    </issue>

@@ -2509,7 +2397,7 @@
        errorLine2="                                                               ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values-en-rIN/strings.xml"
            line="2532"
            line="2560"
            column="64"/>
    </issue>

@@ -2525,7 +2413,7 @@
        errorLine2="                                   ~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values/strings.xml"
            line="5920"
            line="5902"
            column="36"/>
    </issue>

@@ -2541,7 +2429,7 @@
        errorLine2="                                        ^">
        <location
            file="res/values/styles.xml"
            line="248"
            line="171"
            column="41"/>
    </issue>

@@ -2557,7 +2445,7 @@
        errorLine2="                                           ^">
        <location
            file="res/values/styles.xml"
            line="465"
            line="425"
            column="44"/>
    </issue>

@@ -2573,7 +2461,7 @@
        errorLine2="                                           ^">
        <location
            file="res/values/styles.xml"
            line="471"
            line="431"
            column="44"/>
    </issue>

@@ -2589,7 +2477,7 @@
        errorLine2="                                           ^">
        <location
            file="res/values/styles.xml"
            line="472"
            line="432"
            column="44"/>
    </issue>

@@ -2601,12 +2489,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine1="        &lt;item name=&quot;batteryGoodColor&quot;>@color/battery_good_color_light&lt;/item>"
        errorLine2="                                      ^">
        <location
            file="res/values/themes.xml"
            line="31"
            column="40"/>
            line="54"
            column="39"/>
    </issue>

    <issue
@@ -2617,11 +2505,11 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;batteryMaybeColor&quot;>@color/battery_maybe_color_light&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="49"
            line="55"
            column="40"/>
    </issue>

@@ -2633,12 +2521,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine1="        &lt;item name=&quot;batteryBadColor&quot;>@color/battery_bad_color_light&lt;/item>"
        errorLine2="                                     ^">
        <location
            file="res/values/themes.xml"
            line="67"
            column="40"/>
            line="56"
            column="38"/>
    </issue>

    <issue
@@ -2649,12 +2537,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;switchBarBackgroundColor&quot;>@color/switch_bar_background&lt;/item>"
        errorLine2="                                              ^">
        <location
            file="res/values/themes.xml"
            line="85"
            column="40"/>
            line="86"
            column="47"/>
    </issue>

    <issue
@@ -2665,12 +2553,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:statusBarColor&quot;>#00000000&lt;/item>"
        errorLine2="                                            ^">
        <location
            file="res/values/themes.xml"
            line="103"
            column="40"/>
            line="147"
            column="45"/>
    </issue>

    <issue
@@ -2681,12 +2569,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:navigationBarColor&quot;>#00000000&lt;/item>"
        errorLine2="                                                ^">
        <location
            file="res/values/themes.xml"
            line="121"
            column="40"/>
            line="148"
            column="49"/>
    </issue>

    <issue
@@ -2697,12 +2585,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:colorPrimary&quot;>@color/material_grey_100&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:statusBarColor&quot;>#00000000&lt;/item>"
        errorLine2="                                            ^">
        <location
            file="res/values/themes.xml"
            line="197"
            column="43"/>
            line="156"
            column="45"/>
    </issue>

    <issue
@@ -2713,12 +2601,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:colorAccent&quot;>@color/material_blue_700&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:navigationBarColor&quot;>#00000000&lt;/item>"
        errorLine2="                                                ^">
        <location
            file="res/values/themes.xml"
            line="198"
            column="42"/>
            line="157"
            column="49"/>
    </issue>

    <issue
@@ -2729,12 +2617,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:titleTextColor&quot;>@color/material_blue_700&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="199"
            column="45"/>
            file="res/values/themes_suw.xml"
            line="29"
            column="40"/>
    </issue>

    <issue
@@ -2745,12 +2633,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;batteryGoodColor&quot;>@color/battery_good_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="240"
            column="39"/>
            file="res/values/themes_suw.xml"
            line="48"
            column="40"/>
    </issue>

    <issue
@@ -2761,11 +2649,11 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;batteryMaybeColor&quot;>@color/battery_maybe_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="241"
            file="res/values/themes_suw.xml"
            line="67"
            column="40"/>
    </issue>

@@ -2777,12 +2665,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;batteryBadColor&quot;>@color/battery_bad_color_light&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="242"
            column="38"/>
            file="res/values/themes_suw.xml"
            line="86"
            column="40"/>
    </issue>

    <issue
@@ -2793,12 +2681,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;switchBarBackgroundColor&quot;>@color/switch_bar_background&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_dark&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="280"
            column="47"/>
            file="res/values/themes_suw.xml"
            line="105"
            column="40"/>
    </issue>

    <issue
@@ -2809,12 +2697,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:statusBarColor&quot;>#00000000&lt;/item>"
        errorLine1="        &lt;item name=&quot;wifi_signal_color&quot;>@color/setup_wizard_wifi_color_light&lt;/item>"
        errorLine2="                                       ^">
        <location
            file="res/values/themes.xml"
            line="349"
            column="45"/>
            file="res/values/themes_suw.xml"
            line="124"
            column="40"/>
    </issue>

    <issue
@@ -2825,12 +2713,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:navigationBarColor&quot;>#00000000&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:colorPrimary&quot;>@color/material_grey_100&lt;/item>"
        errorLine2="                                          ^">
        <location
            file="res/values/themes.xml"
            line="350"
            column="49"/>
            file="res/values/themes_suw.xml"
            line="187"
            column="43"/>
    </issue>

    <issue
@@ -2841,12 +2729,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:statusBarColor&quot;>#00000000&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:colorAccent&quot;>@color/material_blue_700&lt;/item>"
        errorLine2="                                         ^">
        <location
            file="res/values/themes.xml"
            line="358"
            column="45"/>
            file="res/values/themes_suw.xml"
            line="188"
            column="42"/>
    </issue>

    <issue
@@ -2857,12 +2745,12 @@
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="        &lt;item name=&quot;android:navigationBarColor&quot;>#00000000&lt;/item>"
        errorLine1="        &lt;item name=&quot;android:titleTextColor&quot;>@color/material_blue_700&lt;/item>"
        errorLine2="                                            ^">
        <location
            file="res/values/themes.xml"
            line="359"
            column="49"/>
            file="res/values/themes_suw.xml"
            line="189"
            column="45"/>
    </issue>

    <issue
+1 −1
Original line number Diff line number Diff line
@@ -38,11 +38,11 @@
            android:text="@*android:string/android_start_title"/>

        <ProgressBar
            android:theme="@style/FallbackHomeProgressBar"
            style="@android:style/Widget.Material.ProgressBar.Horizontal"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_marginTop="12.75dp"
            android:colorControlActivated="?android:attr/textColorPrimary"
            android:indeterminate="true"/>

    </LinearLayout>
Loading