Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08908b2b authored by Doris Ling's avatar Doris Ling
Browse files

Adjust alignment for suggestion icon. 

- add margin to the suggestion icon so that it align properly with the
suggestion text.
- also align the action button with the suggestion icon and text.

Change-Id: Ic12e4160d6583cf2d837e65ee5fd5a1ad73d348d
Fixes: 74414989
Test: visual
parent d95668db

res/layout/suggestion_tile_with_button.xml

+10 −7
Original line number Diff line number Diff line
@@ -86,15 +86,18 @@ 
            android:singleLine="true"

            android:textAppearance="@style/TextAppearance.SuggestionSummary" />



        <FrameLayout

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            style="@style/SuggestionCardButton">

            <Button

                android:id="@android:id/primary"

                style="@style/ActionPrimaryButton"

                android:layout_gravity="center"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

            android:layout_marginTop="16dp"

            android:layout_marginBottom="18dp"

                android:text="@string/suggestion_button_text" />

        </FrameLayout>



    </LinearLayout>

res/values/dimens.xml

+4 −0
Original line number Diff line number Diff line
@@ -318,6 +318,10 @@ 
    <dimen name="suggestion_card_inner_margin">12dp</dimen>

    <dimen name="suggestion_card_padding_bottom_one_card">16dp</dimen>

    <dimen name="suggestion_card_corner_radius">2dp</dimen>

    <dimen name="suggestion_card_icon_side_margin">12dp</dimen>

    <dimen name="suggestion_card_button_side_margin">8dp</dimen>

    <dimen name="suggestion_card_button_top_margin">16dp</dimen>

    <dimen name="suggestion_card_button_bottom_margin">18dp</dimen>



    <!-- Padding for the reset screens -->

    <dimen name="reset_checkbox_padding_end">8dp</dimen>

res/values/styles.xml

+10 −0
Original line number Diff line number Diff line
@@ -329,6 +329,16 @@ 
    <style name="SuggestionCardIcon">

        <item name="android:layout_centerHorizontal">false</item>

        <item name="android:layout_alignParentStart">true</item>

        <item name="android:layout_marginStart">@dimen/suggestion_card_icon_side_margin</item>

        <item name="android:layout_marginEnd">@dimen/suggestion_card_icon_side_margin</item>

    </style>



    <style name="SuggestionCardButton">

        <item name="android:layout_gravity">start</item>

        <item name="android:layout_marginStart">@dimen/suggestion_card_button_side_margin</item>

        <item name="android:layout_marginEnd">@dimen/suggestion_card_button_side_margin</item>

        <item name="android:layout_marginTop">@dimen/suggestion_card_button_top_margin</item>

        <item name="android:layout_marginBottom">@dimen/suggestion_card_button_bottom_margin</item>

    </style>



    <style name="TextAppearance.SuggestionTitle"