Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 084a9b3d authored by Matthew DeVore's avatar Matthew DeVore
Browse files

DisplayBlock: replace layout with wider margin 

Remove a layout and instead use a wider margin around blocks. This is
made easier by the introduction of ViewOutline earlier. It also reduces
flicker considerably when switching the active display block in the
prototype implementation b/409354332.

The display_block_padding value has a different meaning after this
patch. Before it included the highlight width. Now it does not include
the highlight width, so to get the old display_block_padding value two
other values need to be summed up: highlight_width and block_padding

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: visual inspection
Bug: b/409354332
Change-Id: I5a6c8cdd12c9b578425f22d360b8a1c49dfa39f1
parent 37953fc9

res/drawable/display_block_background.xml

deleted100644 → 0
+0 −29
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?><!--

  ~ Copyright (C) 2025 The Android Open Source Project

  ~

  ~ Licensed under the Apache License, Version 2.0 (the "License");

  ~ you may not use this file except in compliance with the License.

  ~ You may obtain a copy of the License at

  ~

  ~      http://www.apache.org/licenses/LICENSE-2.0

  ~

  ~ Unless required by applicable law or agreed to in writing, software

  ~ distributed under the License is distributed on an "AS IS" BASIS,

  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

  ~ See the License for the specific language governing permissions and

  ~ limitations under the License.

  ~

  -->



<layer-list xmlns:android="http://schemas.android.com/apk/res/android">



    <item>

        <shape android:shape="rectangle">

            <stroke

                android:color="@color/display_topology_background_color"

                android:width="@dimen/display_block_padding" />

            <corners android:radius="@dimen/display_block_corner_radius" />

        </shape>

    </item>



</layer-list>

res/values/dimens.xml

+1 −1
Original line number Diff line number Diff line
@@ -562,7 +562,7 @@ 
    <!-- Connected displays -->

    <dimen name="display_topology_pane_margin">24dp</dimen>

    <dimen name="display_topology_pane_vertical_margin">24dp</dimen>

    <dimen name="display_block_padding">5dp</dimen>

    <dimen name="display_block_padding">3dp</dimen>

    <dimen name="display_block_highlight_width">2dp</dimen>

    <dimen name="display_block_corner_radius">10dp</dimen>

src/com/android/settings/connecteddevice/display/DisplayBlock.kt

+23 −18
Original line number Diff line number Diff line
@@ -32,8 +32,11 @@ import com.android.settings.R 
class DisplayBlock(val injector: ConnectedDisplayInjector) : FrameLayout(injector.context!!) {

    @VisibleForTesting

    val highlightPx = context.resources.getDimensionPixelSize(R.dimen.display_block_highlight_width)

    val cornerRadiusPx =

    private val cornerRadiusPx =

        context.resources.getDimensionPixelSize(R.dimen.display_block_corner_radius)

    private val displayBlockPaddingPx =

        context.resources.getDimensionPixelSize(R.dimen.display_block_padding)

    private val paneBgColor = context.resources.getColor(R.color.display_topology_background_color)



    private var _displayId: Int? = null
@@ -92,16 +95,19 @@ class DisplayBlock(val injector: ConnectedDisplayInjector) : FrameLayout(injecto 
        }



    val wallpaperView = SurfaceView(context)

    private val backgroundView =

        View(context).apply {

            background = context.getDrawable(R.drawable.display_block_background)

        }

    @VisibleForTesting

    val selectionMarkerView =

        View(context).apply {

            background = context.getDrawable(R.drawable.display_block_selection_marker_background)

        }



    val roundedCornerOutline =

        object : ViewOutlineProvider() {

            override fun getOutline(view: View, outline: Outline) {

                outline.setRoundRect(0, 0, view.width, view.height, cornerRadiusPx.toFloat())

            }

        }



    init {

        isScrollContainer = false

        isVerticalScrollBarEnabled = false
@@ -111,10 +117,13 @@ class DisplayBlock(val injector: ConnectedDisplayInjector) : FrameLayout(injecto 
        stateListAnimator = null



        addView(wallpaperView)

        addView(backgroundView)

        addView(selectionMarkerView)



        wallpaperView.holder.addCallback(holderCallback)



        setBackgroundColor(paneBgColor)

        outlineProvider = roundedCornerOutline

        clipToOutline = true

    }



    /**
@@ -178,23 +187,19 @@ class DisplayBlock(val injector: ConnectedDisplayInjector) : FrameLayout(injecto 
        // The highlight is the outermost border. The highlight is shown outside of the parent

        // FrameLayout so that it consumes the padding between the blocks.

        wallpaperView.layoutParams.let {

            it.width = newWidth

            it.height = newHeight

            it.width = newWidth - 2 * displayBlockPaddingPx

            it.height = newHeight - 2 * displayBlockPaddingPx

            if (it is MarginLayoutParams) {

                it.leftMargin = highlightPx

                it.topMargin = highlightPx

                it.bottomMargin = highlightPx

                it.topMargin = highlightPx

                val totalPaddingPx = highlightPx + displayBlockPaddingPx

                it.leftMargin = totalPaddingPx

                it.topMargin = totalPaddingPx

                it.bottomMargin = totalPaddingPx

                it.topMargin = totalPaddingPx

            }

            wallpaperView.layoutParams = it

        }



        wallpaperView.outlineProvider =

            object : ViewOutlineProvider() {

                override fun getOutline(view: View, outline: Outline) {

                    outline.setRoundRect(0, 0, view.width, view.height, cornerRadiusPx.toFloat())

                }

            }

        wallpaperView.outlineProvider = roundedCornerOutline

        wallpaperView.clipToOutline = true



        // The other two child views are MATCH_PARENT by default so will resize to fill up the