Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0842797a authored by Jason Monk's avatar Jason Monk
Browse files

Fix summary loader lifecycle 

Previous CL accidentally cleared the listening bit too early making
it never actually tell the SummaryProviders to stop listening.

Change-Id: I6af1acc861f6987b33641c40637354c75cf4d708
Fixes: 28306872
parent ac663d2f

src/com/android/settings/dashboard/SummaryLoader.java

+5 −2
Original line number Original line Diff line number Diff line
@@ -97,7 +97,6 @@ public class SummaryLoader { 
    public void setListening(boolean listening) {

    public void setListening(boolean listening) {

        synchronized (mReceivers) {

        synchronized (mReceivers) {

            // Unregister listeners immediately.

            // Unregister listeners immediately.

            mListening = false;

            for (int i = 0; i < mReceivers.size(); i++) {

            for (int i = 0; i < mReceivers.size(); i++) {

                mActivity.unregisterReceiver(mReceivers.get(i));

                mActivity.unregisterReceiver(mReceivers.get(i));

            }

            }
@@ -163,7 +162,11 @@ public class SummaryLoader { 
        if (DEBUG) Log.d(TAG, "Listening " + listening);

        if (DEBUG) Log.d(TAG, "Listening " + listening);

        mListening = listening;

        mListening = listening;

        for (SummaryProvider p : mSummaryMap.keySet()) {

        for (SummaryProvider p : mSummaryMap.keySet()) {

            try {

                p.setListening(listening);

                p.setListening(listening);

            } catch (Exception e) {

                Log.d(TAG, "Problem in setListening", e);

            }

        }

        }

    }

    }