Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00fa2f57 authored by Gustaf Nilklint's avatar Gustaf Nilklint Committed by Johan Redestig
Browse files

Fixed a memory leak in the bluetooth settings 

Release resources in onPause rather than onResume to fix a memory leak.
Without this fix the app will crash if you are in Bluetooth settings
and tap "Device name" and then roate the device a few times.

Change-Id: I57a8346247c13f5113e7c4ea39dde5b29a7359bb
parent e8531ff6

src/com/android/settings/bluetooth/BluetoothSettings.java

+3 −2
Original line number Diff line number Diff line
@@ -161,8 +161,6 @@ public class BluetoothSettings extends PreferenceActivity 


        // Repopulate (which isn't too bad since it's cached in the settings

        // bluetooth manager

        mDevicePreferenceMap.clear();

        mDeviceList.removeAll();

        addDevices();



        if (mScreenType == SCREEN_TYPE_SETTINGS) {
@@ -187,6 +185,9 @@ public class BluetoothSettings extends PreferenceActivity 
    protected void onPause() {

        super.onPause();



        mDevicePreferenceMap.clear();

        mDeviceList.removeAll();



        mLocalManager.setForegroundActivity(null);

        mDevicePreferenceMap.clear();

        mDeviceList.removeAll();