Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00ab92f9 authored by tom hsu's avatar tom hsu
Browse files

Improve potential NPE problem 

 - Move CarrierConfigCache initialization to make sure the instance
   created.

Flag: EXEMPT bug fix
Fix: b/409841639
Test: atest pass
Change-Id: I07bf9eca1d271d0f38c4d12cd8e04d8a6d4623ed
parent 3c8e4222

src/com/android/settings/network/telephony/satellite/SatelliteSettingPreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ public class SatelliteSettingPreferenceController extends 


    public SatelliteSettingPreferenceController(@NonNull Context context, @NonNull String key) {

        super(context, key);

        mCarrierConfigCache = CarrierConfigCache.getInstance(mContext);

    }



    /**
@@ -78,7 +79,6 @@ public class SatelliteSettingPreferenceController extends 
    public void initialize(int subId) {

        logd("initialize(), subId=" + subId);

        mSubId = subId;

        mCarrierConfigCache = CarrierConfigCache.getInstance(mContext);

        mSatelliteManager = mContext.getSystemService(SatelliteManager.class);

        mTelephonyManager = mContext.getSystemService(TelephonyManager.class);

        if (mTelephonyManager != null) {

src/com/android/settings/network/telephony/satellite/SatelliteSettingsPreferenceCategoryController.java

+1 −1
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ public class SatelliteSettingsPreferenceCategoryController extends 


    public SatelliteSettingsPreferenceCategoryController(Context context, String key) {

        super(context, key);

        mCarrierConfigCache = CarrierConfigCache.getInstance(mContext);

    }



    /**
@@ -74,7 +75,6 @@ public class SatelliteSettingsPreferenceCategoryController extends 
    public void init(int subId) {

        Log.d(TAG, "init(), subId=" + subId);

        mSubId = subId;

        mCarrierConfigCache = CarrierConfigCache.getInstance(mContext);

        mSatelliteManager = mContext.getSystemService(SatelliteManager.class);

        mTelephonyManager = mContext.getSystemService(TelephonyManager.class);

        requestIsSatelliteSupported();