Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 007d1b2a authored by Yanting Yang's avatar Yanting Yang
Browse files

Remove stale search result about "Recent location requests" page 

Based on the new design, RecentLocationRequestSeeAllFragment was no
longer used on Location, but it still implemented the indexable
interface to provide stale search result “Recent location requests”
to Settings Search.

Remove the indexable interface from RecentLocationRequestSeeAllFragment
as a quick fix and also correct the related test method name.

Fixes: 192542283
Test: visual
Change-Id: I1a3df5d7319b8831db2f3d3abba19a11b5a83c81
parent cb00a65a

src/com/android/settings/location/RecentLocationRequestSeeAllFragment.java

+2 −10
Original line number Diff line number Diff line
@@ -24,11 +24,9 @@ import com.android.internal.logging.nano.MetricsProto.MetricsEvent; 
import com.android.settings.R;

import com.android.settings.dashboard.DashboardFragment;

import com.android.settings.dashboard.profileselector.ProfileSelectFragment;

import com.android.settings.search.BaseSearchIndexProvider;

import com.android.settingslib.search.SearchIndexable;



/** Dashboard Fragment to display all recent location requests, sorted by recency. */

@SearchIndexable

/** @deprecated Use {@link RecentLocationAccessSeeAllFragment} instead. */

@Deprecated

public class RecentLocationRequestSeeAllFragment extends DashboardFragment {

    private static final String TAG = "RecentLocationReqAll";

    public static final String PATH =
@@ -99,10 +97,4 @@ public class RecentLocationRequestSeeAllFragment extends DashboardFragment { 
                R.string.menu_hide_system);

        updateMenu();

    }



    /**

     * For Search.

     */

    public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =

            new BaseSearchIndexProvider(R.xml.location_recent_requests_see_all);

}

tests/unit/src/com/android/settings/search/CustomSiteMapRegistryTest.java

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ public class CustomSiteMapRegistryTest { 
    }



    @Test

    public void shouldContainRecentLocationRequestSeeAllFragmentPairs() {

    public void shouldContainRecentLocationAccessSeeAllFragmentPairs() {

        assertThat(CustomSiteMapRegistry.CUSTOM_SITE_MAP.get(

                RecentLocationAccessSeeAllFragment.class.getName())).isEqualTo(

                LocationSettings.class.getName());