Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 340cc8b9 authored by 2bllw8's avatar 2bllw8 Committed by Michael Bestas
Browse files

Recorder: Fix warnings 

[BadDaemon: getSystemWindowInsets() is deprecated according to AS,
 but replacing it with the suggested
 getInsets(WindowInsetsCompat.Type.systemBars())
 leads to a compiler error "Cannot find symbol" - therefore mute the
 warning]

Change-Id: Ib4d6f0dd5ed7448d9c828b46d06e26348457d687
parent 034cb714

app/src/main/java/org/lineageos/recorder/ListActivity.java

+1 −3
Original line number Diff line number Diff line
@@ -246,9 +246,7 @@ public class ListActivity extends AppCompatActivity implements RecordingListCall 
                .setTitle(R.string.delete_all_title)

                .setMessage(getString(R.string.delete_all_message))

                .setPositiveButton(R.string.delete, (dialog, which) -> {

                    items.forEach(item -> {

                        MediaProviderHelper.remove(this, item.getUri());

                    });

                    items.forEach(item -> MediaProviderHelper.remove(this, item.getUri()));

                    mAdapter.setData(new ArrayList<>());

                    Utils.cancelShareNotification(this);

                })

app/src/main/java/org/lineageos/recorder/list/RecordingsAdapter.java

+2 −2
Original line number Diff line number Diff line
@@ -146,12 +146,12 @@ public class RecordingsAdapter extends RecyclerView.Adapter<RecordingItemViewHol 


    public void enterSelectionMode() {

        mInSelectionMode = true;

        notifyDataSetChanged();

        notifyItemRangeChanged(0, mData.size());

    }



    public void exitSelectionMode() {

        mSelected.clear();

        mInSelectionMode = false;

        notifyDataSetChanged();

        notifyItemRangeChanged(0, mData.size());

    }

}

app/src/main/java/org/lineageos/recorder/service/GoodQualityRecorder.java

+4 −0
Original line number Diff line number Diff line
@@ -15,8 +15,11 @@ 
 */

package org.lineageos.recorder.service;



import android.Manifest;

import android.media.MediaRecorder;



import androidx.annotation.RequiresPermission;



import java.io.File;

import java.io.IOException;
@@ -28,6 +31,7 @@ public class GoodQualityRecorder implements SoundRecording { 
    private boolean mIsPaused = false;



    @Override

    @RequiresPermission(Manifest.permission.RECORD_AUDIO)

    public void startRecording(File file) throws IOException {

        mRecorder = new MediaRecorder();

        mRecorder.setOutputFile(file);

app/src/main/java/org/lineageos/recorder/service/HighQualityRecorder.java

+4 −0
Original line number Diff line number Diff line
@@ -15,11 +15,14 @@ 
 */

package org.lineageos.recorder.service;



import android.Manifest;

import android.media.AudioFormat;

import android.media.AudioRecord;

import android.media.MediaRecorder;

import android.util.Log;



import androidx.annotation.RequiresPermission;



import org.lineageos.recorder.utils.PcmConverter;

import org.lineageos.recorder.utils.Utils;
@@ -50,6 +53,7 @@ public class HighQualityRecorder implements SoundRecording { 
    private final Semaphore mPauseSemaphore = new Semaphore(1);



    @Override

    @RequiresPermission(Manifest.permission.RECORD_AUDIO)

    public void startRecording(File file) {

        mFile = file;

        mRecord = new AudioRecord(MediaRecorder.AudioSource.DEFAULT,

app/src/main/java/org/lineageos/recorder/service/SoundRecorderService.java

+13 −5
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package org.lineageos.recorder.service;



import android.Manifest;

import android.app.Notification;

import android.app.NotificationChannel;

import android.app.NotificationManager;
@@ -25,6 +26,7 @@ import android.content.BroadcastReceiver; 
import android.content.Context;

import android.content.Intent;

import android.content.IntentFilter;

import android.content.pm.PackageManager;

import android.net.Uri;

import android.os.Environment;

import android.os.IBinder;
@@ -150,7 +152,13 @@ public class SoundRecorderService extends Service { 
        mElapsedTime.set(0);



        try {

            if (checkSelfPermission(Manifest.permission.RECORD_AUDIO)

                    == PackageManager.PERMISSION_GRANTED) {

                mRecorder.startRecording(mRecordFile);

            } else {

                Log.e(TAG, "Missing permission to record audio");

                return START_NOT_STICKY;

            }

        } catch (IOException e) {

            Log.e(TAG, "Error while starting the media recorder", e);

            return START_NOT_STICKY;
@@ -279,7 +287,7 @@ public class SoundRecorderService extends Service { 
        mNotificationManager.createNotificationChannel(notificationChannel);

    }



    @NonNull

    @Nullable

    private Notification createRecordingNotification() {

        if (mNotificationManager == null) {

            return null;