From a963e637ceb4cba75a5f0bd99208131689da0df9 Mon Sep 17 00:00:00 2001
From: Amit Kumar <mr.doc10jl96@gmail.com>
Date: Fri, 22 Jan 2021 20:28:03 +0530
Subject: [PATCH] Following improvements: 1. Make album and video corners
 rounded. 2. Fix photo action bar title color. 3. Change albumlist_label_title
 color to color_default_primary_text.

Change-Id: Id2dba75392bbe470160762e9f7d2af837f13e824
---
 res/values/colors.xml                              |  8 ++++----
 res/values/dimens.xml                              |  2 +-
 res/values/styles.xml                              | 14 +++++++++-----
 src/com/android/gallery3d/app/AlbumPage.java       | 12 ------------
 src/com/android/gallery3d/app/AlbumSetPage.java    | 12 ------------
 src/com/android/gallery3d/app/TimeLinePage.java    | 12 ------------
 .../android/gallery3d/ui/AlbumSetSlotRenderer.java |  6 ++++++
 .../android/gallery3d/ui/AlbumSlotRenderer.java    | 10 ++++++++++
 8 files changed, 30 insertions(+), 46 deletions(-)

diff --git a/res/values/colors.xml b/res/values/colors.xml
index 96260d544..6715375b2 100755
--- a/res/values/colors.xml
+++ b/res/values/colors.xml
@@ -25,18 +25,18 @@
     <color name="albumset_label_background">@color/black_transparent_4</color>
     <color name="albumset_label_title">@color/white</color>
     <color name="albumset_label_count">@color/white</color>
-    <color name="albumlist_label_title">@color/white</color>
+    <color name="albumlist_label_title">@color/color_default_primary_text</color>
 
     <color name="darker_transparent">@color/black_transparent_5</color>
 
     <!-- configuration for album page -->
     <color name="album_background">@color/default_background</color>
-    <color name="album_placeholder">@color/default_background</color>
+    <color name="album_placeholder">@color/white</color>
 
     <!-- configuration for photo page -->
     <color name="photo_background">@color/black</color>
     <color name="photo_placeholder">@color/light_black</color>
-    <color name="photo_page_action_bar">#8A000000</color>
+    <color name="photo_page_action_bar">@color/default_background</color>
     <color name="photo_page_bottom_panel">#8A000000</color>
 
     <!-- configuration for manage cache page -->
@@ -93,5 +93,5 @@
     <color name="timeline_title_background_color">@color/default_background</color>
 
     <color name="navigation_accent_disabled">@color/disable_tab_color</color>
-    <color name="navigation_accent_enabled">@lineageos.platform:color/color_default_blue1</color>
+    <color name="navigation_accent_enabled">@lineageos.platform:color/color_default_accent</color>
 </resources>
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index 49aa5d599..07b72f3d9 100755
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -185,7 +185,7 @@
     <dimen name="timeline_grid_vertical_space">3dp</dimen>
     <dimen name="slot_width">174dp</dimen>
     <dimen name="slot_height">174dp</dimen>
-    <dimen name="toolbar_height">80dp</dimen>
+    <dimen name="toolbar_height">56dp</dimen>
     <dimen name="slot_width_album">116dp</dimen>
     <dimen name="slot_height_album">116dp</dimen>
     <dimen name="crop_icon_size">30dp</dimen>
diff --git a/res/values/styles.xml b/res/values/styles.xml
index 19de51af2..648fee2e7 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -32,7 +32,7 @@
         <item name="android:windowContentOverlay">@null</item>
         <item name="android:colorBackgroundCacheHint">@null</item>
         <item name="android:windowDrawsSystemBarBackgrounds">true</item>
-        <item name="android:statusBarColor">@color/primary</item>
+        <item name="android:statusBarColor">@android:color/transparent</item>
         <item name="android:windowTranslucentStatus">true</item>
         <item name="android:windowTranslucentNavigation">false</item>
         <item name="android:windowActionModeOverlay">true</item>
@@ -319,10 +319,13 @@
     </style>
 
     <style name="AppTheme" parent="Theme.AppCompat.Light">
+        <item name="colorPrimary">@color/primary</item>
+        <item name="colorPrimaryDark">@color/primaryDark</item>
+        <item name="android:colorPrimary">@color/primary</item>
+        <item name="android:colorPrimaryDark">@color/primaryDark</item>
         <item name="android:windowDisablePreview">true</item>
         <item name="android:windowDrawsSystemBarBackgrounds">true</item>
-        <item name="android:windowBackground">@android:color/black</item>
-        <item name="android:statusBarColor">@color/primary</item>
+        <item name="android:windowBackground">@color/primary</item>
         <item name="android:windowTranslucentNavigation">false</item>
         <item name="android:windowActionBar">false</item>
         <item name="android:windowActionModeOverlay">true</item>
@@ -339,10 +342,11 @@
         <item name="android:statusBarColor">#ab5810</item>
     </style>
 
-    <style name="ToolbarTheme" parent="android:Theme.Material" >
+    <style name="ToolbarTheme" parent="android:Theme.Material.Light" >
         <item name="android:actionOverflowButtonStyle">@style/WhiteOverflow</item>
         <item name="colorPrimary">@color/primary</item>
         <item name="colorPrimaryDark">@color/primaryDark</item>
+        <item name="android:colorControlNormal">@color/color_default_primary_text</item>
     </style>
 
     <style name="MytoolbarStyle" parent="android:Theme.Material.Light" >
@@ -362,7 +366,7 @@
         <item name="android:src">@drawable/multiselect_more</item>
     </style>
     <style name="WhiteOverflow" parent="@android:style/Widget.Material.ActionButton.Overflow">
-        <item name="android:src">@drawable/more</item>
+        <item name="android:src">@lineageos.platform:drawable/ic_menu</item>
     </style>
     <style name="FilterShowActionBar" parent="@android:style/Widget.Material.Light.ActionBar">
         <item name="android:background">@color/edit_actionbar_background</item>
diff --git a/src/com/android/gallery3d/app/AlbumPage.java b/src/com/android/gallery3d/app/AlbumPage.java
index 61cefde45..9c9290444 100644
--- a/src/com/android/gallery3d/app/AlbumPage.java
+++ b/src/com/android/gallery3d/app/AlbumPage.java
@@ -634,7 +634,6 @@ public class AlbumPage extends ActivityState implements GalleryActionBar.Cluster
         } else {
             inflator.inflate(R.menu.album, menu);
             mActionBar.setTitle(mMediaSet.getName());
-            changeMenuItemColor(menu);
 
             FilterUtils.setupMenuItems(mActionBar, mMediaSetPath, true);
 
@@ -654,17 +653,6 @@ public class AlbumPage extends ActivityState implements GalleryActionBar.Cluster
         return true;
     }
 
-    private void changeMenuItemColor(Menu menu){
-        for(int i = 0; i < menu.size(); i++){
-            Drawable drawable = menu.getItem(i).getIcon();
-            if(drawable != null) {
-                drawable.mutate();
-                drawable.setColorFilter(mActivity.getResources().getColor(R.color.color_default_primary_text), PorterDuff.Mode.SRC_ATOP);
-            }
-        }
-
-    }
-
     private boolean allVideoFiles() {
         if (mMediaSet == null)
             return false;
diff --git a/src/com/android/gallery3d/app/AlbumSetPage.java b/src/com/android/gallery3d/app/AlbumSetPage.java
index 5f707309d..8c2368386 100755
--- a/src/com/android/gallery3d/app/AlbumSetPage.java
+++ b/src/com/android/gallery3d/app/AlbumSetPage.java
@@ -626,23 +626,11 @@ public class AlbumSetPage extends ActivityState implements
             moreItem.setVisible(mActivity.getResources().getBoolean(
                     R.bool.config_show_more_images));
             mActionBar.setTitle(R.string.albums_title);
-            changeMenuItemColor(menu);
         }
         return true;
     }
 
 
-    private void changeMenuItemColor(Menu menu){
-        for(int i = 0; i < menu.size(); i++){
-            Drawable drawable = menu.getItem(i).getIcon();
-            if(drawable != null) {
-                drawable.mutate();
-                drawable.setColorFilter(mActivity.getResources().getColor(R.color.color_default_primary_text), PorterDuff.Mode.SRC_ATOP);
-            }
-        }
-
-    }
-
     @Override
     protected boolean onItemSelected(MenuItem item) {
         Activity activity = mActivity;
diff --git a/src/com/android/gallery3d/app/TimeLinePage.java b/src/com/android/gallery3d/app/TimeLinePage.java
index 471bf8cb1..a2f85e8fe 100755
--- a/src/com/android/gallery3d/app/TimeLinePage.java
+++ b/src/com/android/gallery3d/app/TimeLinePage.java
@@ -590,7 +590,6 @@ public class TimeLinePage extends ActivityState implements
         } else {
             inflator.inflate(R.menu.album, menu);
             actionBar.setTitle(R.string.timeline_title);
-            changeMenuItemColor(menu);
 
             FilterUtils.setupMenuItems(actionBar, mMediaSetPath, true);
             //menu.findItem(R.id.action_group_by).setVisible(mShowClusterMenu);
@@ -601,17 +600,6 @@ public class TimeLinePage extends ActivityState implements
         return true;
     }
 
-    private void changeMenuItemColor(Menu menu){
-        for(int i = 0; i < menu.size(); i++){
-            Drawable drawable = menu.getItem(i).getIcon();
-            if(drawable != null) {
-                drawable.mutate();
-                drawable.setColorFilter(mActivity.getResources().getColor(R.color.color_default_primary_text), PorterDuff.Mode.SRC_ATOP);
-            }
-        }
-
-    }
-
     private void prepareAnimationBackToFilmstrip(int slotIndex) {
         if (mAlbumDataAdapter == null || !mAlbumDataAdapter.isActive(slotIndex)) return;
         MediaItem item = mAlbumDataAdapter.get(slotIndex);
diff --git a/src/com/android/gallery3d/ui/AlbumSetSlotRenderer.java b/src/com/android/gallery3d/ui/AlbumSetSlotRenderer.java
index 264325a91..6fc17ca92 100644
--- a/src/com/android/gallery3d/ui/AlbumSetSlotRenderer.java
+++ b/src/com/android/gallery3d/ui/AlbumSetSlotRenderer.java
@@ -164,6 +164,11 @@ public class AlbumSetSlotRenderer extends AbstractSlotRenderer {
         } else if (mInSelectionMode && mSelectionManager.isItemSelected(entry.setPath)) {
             drawSelectedFrame(canvas, width, height);
         }
+
+        if (entry.album != null) {
+            drawRoundedOverlay(canvas, width, height);
+        }
+        
         return renderRequestFlags;
     }
 
@@ -181,6 +186,7 @@ public class AlbumSetSlotRenderer extends AbstractSlotRenderer {
             entry.content = content;
         }
         drawContent(canvas, content, width, height, entry.rotation);
+
         if ((content instanceof FadeInTexture) &&
                 ((FadeInTexture) content).isAnimating()) {
             renderRequestFlags |= SlotView.RENDER_MORE_FRAME;
diff --git a/src/com/android/gallery3d/ui/AlbumSlotRenderer.java b/src/com/android/gallery3d/ui/AlbumSlotRenderer.java
index a4096dc95..6112e7fa6 100644
--- a/src/com/android/gallery3d/ui/AlbumSlotRenderer.java
+++ b/src/com/android/gallery3d/ui/AlbumSlotRenderer.java
@@ -215,6 +215,16 @@ public class AlbumSlotRenderer extends AbstractSlotRenderer {
                 && mSelectionManager.isItemSelected(entry.path)) {
             drawSelectedFrame(canvas, width, height);
         }
+
+        if (entry.path != null) {
+            if (!mIsGridViewShown) {
+                int minSize = Math.min(width, height);
+                drawRoundedOverlay(canvas, minSize, minSize);
+            } else {
+                drawRoundedOverlay(canvas, width, height);
+            }
+        }
+
         return renderRequestFlags;
     }
 
-- 
GitLab