Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb3125e4 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh Committed by LuK1337
Browse files

Use -Werror in packages/apps/Gallery2 

* Keep constant-conversion warnings to fix later.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib93e954e025fd2f0202960df20583b50b97fce7f
parent 8ae4143e

jni/Android.mk

+10 −1
Original line number Diff line number Diff line 
LOCAL_PATH:= $(call my-dir)



Gallery2_jni_cflags := \

    -Wall -Wextra -Werror \

    -Wno-error=constant-conversion \

    -Wno-unused-parameter \



# to fix implicit conversion from 'int' to 'char', (255 to -1, 128 to -128)



include $(CLEAR_VARS)



LOCAL_CFLAGS += -DEGL_EGLEXT_PROTOTYPES

LOCAL_CFLAGS += $(Gallery2_jni_cflags)



LOCAL_SRC_FILES := jni_egl_fence.cpp
@@ -45,6 +53,7 @@ LOCAL_SRC_FILES := filters/gradient.c \ 
                   filters/kmeans.cc



LOCAL_CFLAGS += -ffast-math -O3 -funroll-loops

LOCAL_CFLAGS += $(Gallery2_jni_cflags)

LOCAL_LDLIBS := -llog -ljnigraphics

LOCAL_ARM_MODE := arm

jni_jpegstream/Android.mk

+1 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ LOCAL_SDK_VERSION := 17 
LOCAL_ARM_MODE := arm



LOCAL_CFLAGS    += -ffast-math -O3 -funroll-loops

LOCAL_CFLAGS += -Wall -Wextra -Werror

LOCAL_CPPFLAGS += $(JNI_CFLAGS)

LOCAL_LDLIBS := -llog