From d7c2e78f6989c3e726a03099f9150d757b93d66d Mon Sep 17 00:00:00 2001 From: Mohit Mali Date: Wed, 6 Jan 2021 17:50:54 +0530 Subject: [PATCH] Completed the polishing work mentioned --- AndroidManifest-gradle.xml | 3 ++- res/layout/activity_base.xml | 7 ++++--- res/layout/edit_queue_list_item.xml | 2 +- res/layout/list_item_common.xml | 1 + res/layout/pref_category_view.xml | 10 ++++++++++ res/values/colors.xml | 6 ++++-- res/values/dimens.xml | 7 ++++++- res/values/styles.xml | 5 +++++ res/xml/settings.xml | 9 ++++++--- src/org/lineageos/eleven/adapters/SongAdapter.java | 2 ++ .../eleven/ui/activities/SearchActivity.java | 12 +++++++++++- .../eleven/ui/activities/SettingsActivity.java | 5 ++--- .../eleven/widgets/PlayPauseProgressButton.java | 5 +++++ 13 files changed, 59 insertions(+), 15 deletions(-) create mode 100644 res/layout/pref_category_view.xml diff --git a/AndroidManifest-gradle.xml b/AndroidManifest-gradle.xml index 8a8e6fcf..b9d2e756 100644 --- a/AndroidManifest-gradle.xml +++ b/AndroidManifest-gradle.xml @@ -118,7 +118,8 @@ + android:label="@string/menu_settings" + android:theme="@style/Eleven.Theme"/> @@ -102,6 +102,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center_horizontal" + android:layout_marginBottom="5dp" android:background="@drawable/rounded_corner_rect"> diff --git a/res/layout/edit_queue_list_item.xml b/res/layout/edit_queue_list_item.xml index e6a86248..55e2f617 100644 --- a/res/layout/edit_queue_list_item.xml +++ b/res/layout/edit_queue_list_item.xml @@ -26,7 +26,7 @@ android:layout_height="@dimen/drag_and_drop_height" android:layout_centerVertical="true" android:scaleType="fitXY" - android:tint="@color/player_action_bar_subtitle_text_color" + android:tint="@color/lineage_blue_color" android:src="@drawable/gripper_light" /> diff --git a/res/layout/pref_category_view.xml b/res/layout/pref_category_view.xml new file mode 100644 index 00000000..29268798 --- /dev/null +++ b/res/layout/pref_category_view.xml @@ -0,0 +1,10 @@ + + diff --git a/res/values/colors.xml b/res/values/colors.xml index 5bcc2bd3..f38d574f 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -67,6 +67,8 @@ @lineageos.platform:color/color_default_primary_text @color/default_text_color_light + #D6D6D6 + @color/white @@ -104,7 +106,7 @@ @color/white - @color/player_control_background_color + @color/circular_ring_bg_color @color/lineage_blue_color @@ -186,7 +188,7 @@ @color/main_action_bar_text_color @color/header_action_bar_text_color - @color/header_action_bar_text_color + @color/header_action_bar_text_color_active @color/header_action_bar_text_color @color/player_control_color diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 74e4d71e..4977a0cc 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -169,6 +169,7 @@ 20.0dip + 25.0dip 0.0dip @@ -218,5 +219,9 @@ 2dp 8dp - 4dp + 0dp + + + 15dp + diff --git a/res/values/styles.xml b/res/values/styles.xml index 1ab22202..822dd102 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -36,6 +36,10 @@ @lineageos.platform:drawable/ic_back + + diff --git a/res/xml/settings.xml b/res/xml/settings.xml index 9b7ed84e..24cc8416 100644 --- a/res/xml/settings.xml +++ b/res/xml/settings.xml @@ -36,7 +36,8 @@ - + - + - + if (mCurrentQueuePosition == position) { // make it visible playPauseProgressButton.enableAndShow(); + playPauseProgressButton.setPlayPauseButton(getContext().getResources().getColor(R.color.lineage_blue_color)); playPauseContainer.setVisibility(View.VISIBLE); } else { // hide it diff --git a/src/org/lineageos/eleven/ui/activities/SearchActivity.java b/src/org/lineageos/eleven/ui/activities/SearchActivity.java index 6b130a43..8a3dbb92 100644 --- a/src/org/lineageos/eleven/ui/activities/SearchActivity.java +++ b/src/org/lineageos/eleven/ui/activities/SearchActivity.java @@ -48,6 +48,7 @@ import android.widget.AbsListView.OnScrollListener; import android.widget.AdapterView; import android.widget.AdapterView.OnItemClickListener; import android.widget.ArrayAdapter; +import android.widget.EditText; import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.ListView; @@ -357,7 +358,7 @@ public class SearchActivity extends FragmentActivity implements getSupportLoaderManager().initLoader(HISTORY_LOADER, null, mSearchHistoryCallback); } - actionBar.setBackgroundDrawable(new ColorDrawable(fetchAccentColor(this))); + actionBar.setBackgroundDrawable(new ColorDrawable(getResources().getColor(R.color.primary))); } /** @@ -381,6 +382,7 @@ public class SearchActivity extends FragmentActivity implements // to this later //mListView.setEmptyView(mLoadingEmptyContainer); + // load the search history list view mSearchHistoryListView = (ListView)findViewById(R.id.list_search_history); mSearchHistoryListView.setOnItemClickListener(new OnItemClickListener() { @@ -443,6 +445,14 @@ public class SearchActivity extends FragmentActivity implements ImageView searchIcon = (ImageView)mSearchView.findViewById(searchButtonId); searchIcon.setLayoutParams(new LinearLayout.LayoutParams(0, 0)); + + int id = mSearchView.getContext() + .getResources() + .getIdentifier("android:id/search_src_text", null, null); + EditText searchEditText = (EditText) mSearchView.findViewById(id); + searchEditText.setTextColor(getResources().getColor(R.color.header_action_bar_text_color_active)); + searchEditText.setHintTextColor(getResources().getColor(R.color.header_action_bar_text_color)); + searchItem.setOnActionExpandListener(new MenuItem.OnActionExpandListener() { @Override public boolean onMenuItemActionExpand(MenuItem item) { diff --git a/src/org/lineageos/eleven/ui/activities/SettingsActivity.java b/src/org/lineageos/eleven/ui/activities/SettingsActivity.java index d34cc6a8..02bd97e7 100644 --- a/src/org/lineageos/eleven/ui/activities/SettingsActivity.java +++ b/src/org/lineageos/eleven/ui/activities/SettingsActivity.java @@ -20,7 +20,6 @@ import android.content.DialogInterface.OnClickListener; import android.content.SharedPreferences; import android.content.SharedPreferences.OnSharedPreferenceChangeListener; import android.content.pm.PackageManager; -import android.graphics.drawable.ColorDrawable; import android.os.Build; import android.os.Bundle; import android.preference.Preference; @@ -73,7 +72,7 @@ public class SettingsActivity extends PreferenceActivity implements OnSharedPref } catch (PackageManager.NameNotFoundException e) { } - getActionBar().setBackgroundDrawable(new ColorDrawable(fetchAccentColor(this))); +// getActionBar().setBackgroundDrawable(new ColorDrawable(getResources().getColor(R.color.primary))); } /** @@ -157,7 +156,7 @@ public class SettingsActivity extends PreferenceActivity implements OnSharedPref Window window = getWindow(); window.addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS); - window.setStatusBarColor(darkenColor(color_accent)); +// window.setStatusBarColor(darkenColor(color_accent)); } return color_accent; diff --git a/src/org/lineageos/eleven/widgets/PlayPauseProgressButton.java b/src/org/lineageos/eleven/widgets/PlayPauseProgressButton.java index 9f4eb26a..9a215873 100644 --- a/src/org/lineageos/eleven/widgets/PlayPauseProgressButton.java +++ b/src/org/lineageos/eleven/widgets/PlayPauseProgressButton.java @@ -17,6 +17,7 @@ package org.lineageos.eleven.widgets; import android.content.Context; +import android.graphics.PorterDuff; import android.util.AttributeSet; import android.util.Log; import android.view.MotionEvent; @@ -94,6 +95,10 @@ public class PlayPauseProgressButton extends FrameLayout { mProgressBar.setRotation(-90); } + public void setPlayPauseButton(int color){ + mPlayPauseButton.setColorFilter(color, PorterDuff.Mode.SRC_ATOP); + } + /** * Enable and shows the container */ -- GitLab