Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f433d20a authored by Steve McKay's avatar Steve McKay
Browse files

Improve debug info. 

Add generic section title support to TableView.
Add debug section title.
Use sentence case for debug labels.
Add more debug values (like weblinkable!)
Minor padding layout tweaks.
Move Julian's sweet row update logic into base class, use that from Debug (solving a bug).

Bug: 63635841, 63638300
Test: Build and view the goodness.
Change-Id: I8f66b4f75b886b366b4eeff65afe2ac104df45d1
parent 9fca181f

AndroidManifest.xml

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ 
        </activity>



        <activity

            android:name=".inspector.DocumentInspectorActivity"

            android:name=".inspector.InspectorActivity"

            android:label="@string/menu_inspector"

            android:icon="@drawable/launcher_icon"

            android:theme="@style/DocumentsTheme">

res/layout/document_inspector_fragment.xml

+4 −2
Original line number Diff line number Diff line
@@ -22,11 +22,13 @@ 
    <LinearLayout

        android:orientation="vertical"

        android:layout_width="match_parent"

        android:layout_height="match_parent">

        android:layout_height="match_parent"

        android:paddingBottom="5dp">



        <com.android.documentsui.inspector.HeaderView

            android:id="@+id/inspector_header_view"

            android:layout_width="match_parent"

            android:paddingBottom="5dp"

            android:layout_height="@dimen/inspector_header_height" />



        <com.android.documentsui.inspector.DetailsView

res/layout/inspector_action_view.xml

+15 −16
Original line number Diff line number Diff line
@@ -14,36 +14,33 @@ 
     limitations under the License.

-->

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

    android:paddingLeft="16dp"

    android:paddingRight="16dp"

    android:layout_width="match_parent"

    android:layout_height="match_parent">



    <TextView

        android:id="@+id/action_header"

        android:layout_height="48dp"

        android:layout_width="wrap_content"

        android:fontFamily="sans-serif-medium"

        android:textSize="14sp"

        android:color="@color/material_subheader"

        android:gravity="center_vertical"/>

    <include

        layout="@layout/inspector_section_title"

        android:id="@+id/action_header" />



    <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

        android:id="@+id/default_app_info"

	    android:paddingLeft="16dp"

	    android:paddingRight="16dp"

        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:id="@+id/default_app_info"

        android:paddingBottom="10dp"

        android:layout_below="@id/action_header">



        <ImageView

            android:id="@+id/app_icon"

            android:paddingLeft="5dp"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:id="@+id/app_icon"/>

            android:layout_height="wrap_content" />



        <TextView

            android:id="@+id/app_name"

            android:paddingLeft="16dp"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:id="@+id/app_name"

            android:paddingLeft="5dp"

            android:layout_toRightOf="@id/app_icon"

            android:layout_centerVertical="true"/>
@@ -54,5 +51,7 @@ 
            android:layout_alignParentRight="true"

            android:layout_centerVertical="true"

            android:background="@null"/>



        </RelativeLayout>



</RelativeLayout>

res/layout/inspector_section_title.xml

0 → 100644
+29 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!--

    Copyright (C) 2017 The Android Open Source Project



    Licensed under the Apache License, Version 2.0 (the "License");

    you may not use this file except in compliance with the License.

    You may obtain a copy of the License at



         http://www.apache.org/licenses/LICENSE-2.0



    Unless required by applicable law or agreed to in writing, software

    distributed under the License is distributed on an "AS IS" BASIS,

    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

    See the License for the specific language governing permissions and

    limitations under the License.

-->

<TextView

    xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_height="match_parent"

    android:layout_width="match_parent"

    android:paddingTop="10dp"

    android:paddingBottom="10dp"

    android:paddingLeft="16dp"

    android:layout_gravity="center_vertical"

    android:fontFamily="sans-serif-medium"

    android:textSize="14sp"

    android:textColor="@color/inspector_section_title">



</TextView>

res/layout/table_key_value_row.xml

+2 −1
Original line number Diff line number Diff line
@@ -19,7 +19,8 @@ 
    android:orientation="horizontal"

    android:layout_width="match_parent"

    android:layout_height="match_parent"

    android:paddingTop="20dp"

    android:paddingTop="10dp"

    android:paddingBottom="10dp"

    android:paddingLeft="16dp">



    <TextView