Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1e4cce4 authored by Ian Rogers's avatar Ian Rogers Committed by Garfield Tan
Browse files

Fix two confusing naming issues 

android.R.string.yes is not "Yes" but "OK"; prefer android.R.string.ok for clarity
android.R.string.no is not "No" but "Cancel"; prefer android.R.string.cancel for clarity
Found by Error Prone.
Bug: 27723540

Change-Id: Ia6f58a7e7543ad1cc4e4722de8d095d1de8df034
(cherry picked from commit d73ff581f32631b6ed7e3c81d4fa2bbca2580865)
parent 19cf55b1

src/com/android/documentsui/dirlist/DirectoryFragment.java

+2 −2
Original line number Diff line number Diff line
@@ -877,7 +877,7 @@ public class DirectoryFragment extends Fragment 
                new AlertDialog.Builder(getActivity())

                    .setView(message)

                    .setPositiveButton(

                         android.R.string.yes,

                         android.R.string.ok,

                         new DialogInterface.OnClickListener() {

                            public void onClick(DialogInterface dialog, int id) {

                                // Finish selection mode first which clears selection so we
@@ -895,7 +895,7 @@ public class DirectoryFragment extends Fragment 
                                        getActivity(), docs, srcParent, getDisplayState().stack);

                            }

                        })

                    .setNegativeButton(android.R.string.no, null)

                    .setNegativeButton(android.R.string.cancel, null)

                    .show();

            }

        }.execute(selected);