Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c69ad262 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Don't show new-window item in Downloads per Gabe." into nyc-dev

parents 7d9d4338 24917427
Loading
Loading
Loading
Loading
+6 −11
Original line number Diff line number Diff line
@@ -218,23 +218,18 @@ public abstract class BaseActivity extends Activity
        state.showAdvanced = Shared.shouldShowDeviceRoot(this, intent);
        // Menu option is shown for whitelisted intents if advanced roots are not shown by default.
        state.showAdvancedOption = !state.showAdvanced && (
                !directLaunch(intent) ||
                state.action == ACTION_OPEN ||
                state.action == ACTION_CREATE ||
                state.action == ACTION_OPEN_TREE ||
                state.action == ACTION_PICK_COPY_DESTINATION ||
                state.action == ACTION_GET_CONTENT);
                Shared.shouldShowFancyFeatures(this)
                || state.action == ACTION_OPEN
                || state.action == ACTION_CREATE
                || state.action == ACTION_OPEN_TREE
                || state.action == ACTION_PICK_COPY_DESTINATION
                || state.action == ACTION_GET_CONTENT);

        if (DEBUG) Log.d(mTag, "Created new state object: " + state);

        return state;
    }

    private static boolean directLaunch(Intent intent) {
        return LauncherActivity.isLaunchUri(intent.getData())
                && intent.hasExtra(Shared.EXTRA_STACK);
    }

    public void setRootsDrawerOpen(boolean open) {
        mNavigator.revealRootsDrawer(open);
    }
+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ public class FilesActivity extends BaseActivity {
        createDir.setEnabled(canCreateDirectory());
        pasteFromCb.setEnabled(mClipper.hasItemsToPaste());
        settings.setVisible(root.hasSettings());
        newWindow.setVisible(true);
        newWindow.setVisible(Shared.shouldShowFancyFeatures(this));

        Menus.disableHiddenItems(menu, pasteFromCb);
        // It hides icon if searching in progress
+19 −5
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ import android.content.Context;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.provider.DocumentsContract;
import android.support.annotation.Nullable;
import android.util.Log;

@@ -44,6 +45,15 @@ public class LauncherActivity extends Activity {
    private static final String LAUNCH_CONTROL_AUTHORITY = "com.android.documentsui.launchControl";
    private static final String TAG = "LauncherActivity";

    // Array of boolean extras that should be copied when creating new launch intents.
    // Missing intents will be ignored.
    private static final String[] PERSISTENT_BOOLEAN_EXTRAS = {
        DocumentsContract.EXTRA_SHOW_FILESIZE,
        DocumentsContract.EXTRA_SHOW_ADVANCED,
        DocumentsContract.EXTRA_FANCY_FEATURES,
        Shared.EXTRA_PRODUCTIVITY_MODE
    };

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
@@ -94,11 +104,7 @@ public class LauncherActivity extends Activity {
        // Relay any config overrides bits present in the original intent.
        Intent original = activity.getIntent();
        if (original != null) {
            if (original.hasExtra(Shared.EXTRA_PRODUCTIVITY_MODE)) {
                intent.putExtra(
                        Shared.EXTRA_PRODUCTIVITY_MODE,
                        original.getBooleanExtra(Shared.EXTRA_PRODUCTIVITY_MODE, false));
            }
            copyExtras(original, intent);
            if (original.hasExtra(Intent.EXTRA_TITLE)) {
                intent.putExtra(
                        Intent.EXTRA_TITLE,
@@ -108,6 +114,14 @@ public class LauncherActivity extends Activity {
        return intent;
    }

    private static void copyExtras(Intent src, Intent dest) {
        for (String extra : PERSISTENT_BOOLEAN_EXTRAS) {
            if (src.hasExtra(extra)) {
                dest.putExtra(extra, src.getBooleanExtra(extra, false));
            }
        }
    }

    private static Uri buildLaunchUri() {
        return new Uri.Builder()
                .authority(LAUNCH_CONTROL_AUTHORITY)
+10 −7
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@

package com.android.documentsui;

import android.app.Activity;
import android.app.AlertDialog;
import android.content.Context;
import android.content.Intent;
@@ -180,13 +181,6 @@ public final class Shared {
        }
    }

    /*
     * Returns true if app is running in "productivity mode".
     */
    public static boolean productivityMode(Context context) {
        return context.getResources().getBoolean(R.bool.productivity_device);
    }

    /*
     * Returns true if app is running in "productivity mode".
     */
@@ -210,4 +204,13 @@ public final class Shared {
        return isProductivityMode(context, intent)
                || intent.getBooleanExtra(DocumentsContract.EXTRA_SHOW_ADVANCED, false);
    }

    /**
     * Returns true if device root should be shown.
     */
    public static boolean shouldShowFancyFeatures(Activity activity) {
        Intent intent = activity.getIntent();
        return isProductivityMode(activity, intent)
                || intent.getBooleanExtra(DocumentsContract.EXTRA_FANCY_FEATURES, false);
    }
}