Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6451832 authored by Ben Lin's avatar Ben Lin
Browse files

Re-enable focus highlight on root list.

Regression was due to the fact we started using a transparent list
selector after switching to manually triggering ripples ourselves.
Without an opaque selector, list view now no longer displays any visual
focus when an item is focused. Using a custom selector that's only for
focus fixes this.

Bug: 30783220
Change-Id: I538110f7a7c0857e2c422867bfb7bbcbe381685d
parent 20015cf8
Loading
Loading
Loading
Loading
+25 −0
Original line number Diff line number Diff line
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (C) 2016 The Android Open Source Project

     Licensed under the Apache License, Version 2.0 (the "License");
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at

          http://www.apache.org/licenses/LICENSE-2.0

     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and
     limitations under the License.
-->

<selector xmlns:android="http://schemas.android.com/apk/res/android">

  <item
    android:state_focused="true"
    android:state_pressed="false">
      <color android:color="?attr/colorControlHighlight" />
  </item>

</selector>
 No newline at end of file
+1 −2
Original line number Diff line number Diff line
@@ -19,6 +19,5 @@
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:paddingTop="8dp"
    android:listSelector="@android:color/transparent"
    android:drawSelectorOnTop="true"
    android:listSelector="@drawable/root_list_selector"
    android:divider="@null" />