Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b575c120 authored by Aditya's avatar Aditya
Browse files

Fix selected chip text visibility in high contrast. 

Defined a new color to be used when the chips are in selected mode. The
color takes values white and black in light mode and dark mode
respectively.

Bug: 325007218
Test: Screenshots
Screenshots: go/b325007218screenshots
Change-Id: Ife9b65a42ac3f6b43d6a1772610928fe230fe116
parent 403ca261

res/color/search_chip_text_color.xml

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ 
  -->



<selector xmlns:android="http://schemas.android.com/apk/res/android">

    <item android:state_selected="true" android:color="?android:colorControlActivated"/>

    <item android:state_selected="true" android:color="@color/search_chip_text_selected_color"/>

    <item android:state_enabled="true" android:color="?android:textColorSecondary"/>

    <item android:state_enabled="false" android:color="?android:textColorSecondary" android:alpha="0.3"/>

</selector>
 
 No newline at end of file

res/drawable/ic_check.xml

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ Copyright (C) 2018 The Android Open Source Project 
        android:height="24dp"

        android:viewportWidth="24.0"

        android:viewportHeight="24.0"

        android:tint="?android:colorControlActivated">

        android:tint="@color/search_chip_text_selected_color">

    <path

        android:fillColor="@android:color/white"

        android:pathData="vM9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z"/>

res/values-night/colors.xml

+2 −0
Original line number Diff line number Diff line
@@ -35,4 +35,6 @@ 
    <color name="list_item_selected_background_color">?android:colorSecondary</color>



    <color name="fragment_pick_active_text_color">#202124</color> <!-- Grey 900 -->



    <color name="search_chip_text_selected_color">@android:color/black</color>

</resources>

res/values/colors.xml

+2 −0
Original line number Diff line number Diff line
@@ -67,4 +67,6 @@ 
  <color name="fragment_pick_inactive_text_color">#5F6368</color>

  <color name="fragment_pick_active_button_color">@color/primary</color>

  <color name="fragment_pick_active_text_color">@android:color/white</color>



  <color name="search_chip_text_selected_color">@android:color/white</color>

</resources>