Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b094f2a5 authored by Cassy Chun-Crogan's avatar Cassy Chun-Crogan
Browse files

[DocsUI M3] Fix corners and selection state colours 

Update the corner radii and the selection state colours to match the
figma spec.

See screenshots at b/381962394#comment2.

Bug: 381962394
Test: m DocumentsUIGoogle && manual inspection
Flag: com.android.documentsui.flags.use_material3
Change-Id: I90cf16fe1e96bb225b804dd66ac6ba0ccdac33bc
parent fc93ee6f

res/flag(com.android.documentsui.flags.use_material3)/color/doc_list_item_label_color.xml

+3 −1
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 
  -->



<selector xmlns:android="http://schemas.android.com/apk/res/android">

    <item android:state_selected="true" android:color="?attr/colorOnPrimary" />

    <item

        android:color="?attr/colorOnPrimaryContainer"

        android:state_selected="true" />

    <item android:color="?attr/colorOnSurface" />

</selector>

res/flag(com.android.documentsui.flags.use_material3)/color/doc_list_item_subtitle_color.xml

+3 −1
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 
  -->



<selector xmlns:android="http://schemas.android.com/apk/res/android">

    <item android:state_selected="true" android:color="?attr/colorOnPrimary" />

    <item

        android:color="?attr/colorOnPrimaryContainer"

        android:state_selected="true" />

    <item android:color="?attr/colorOnSurfaceVariant" />

</selector>

res/flag(com.android.documentsui.flags.use_material3)/drawable/bottom_sheet_dialog_background.xml

+5 −4
Original line number Diff line number Diff line
@@ -17,8 +17,9 @@ 


    <solid android:color="?android:attr/colorBackground" />



    <corners android:topLeftRadius="@dimen/grid_item_radius"

             android:topRightRadius="@dimen/grid_item_radius"

    <corners

        android:topLeftRadius="@dimen/bottom_sheet_dialog_radius"

        android:topRightRadius="@dimen/bottom_sheet_dialog_radius"

        android:bottomLeftRadius="0dp"

        android:bottomRightRadius="0dp"/>

res/flag(com.android.documentsui.flags.use_material3)/drawable/list_item_background.xml

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ 
     limitations under the License.

-->



<!-- Use @color/list_item_selected_background_color instead of the "?attr/colorPrimary"

<!-- Use @color/list_item_selected_background_color instead of the "?attr/colorPrimaryContainer"

     because the variable is exposed in overlayable.xml. -->

<selector xmlns:android="http://schemas.android.com/apk/res/android">

    <!-- selected -->

res/flag(com.android.documentsui.flags.use_material3)/values/colors.xml

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ 
  <color name="edge_effect">@android:color/black</color>



  <color name="list_divider_color">#1f000000</color>

  <color name="list_item_selected_background_color">?attr/colorPrimary</color>

  <color name="list_item_selected_background_color">?attr/colorPrimaryContainer</color>

  <!-- This is used when the app bar is in pinned mode inside the CollapsingToolbarLayout.

       The code in NavigationViewManager assume the value should be a plain color value so we can't

       use the theme attribute "?attr/colorSurfaceContainerHigh" (which is a reference) here, hence