Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af08dfed authored by Steve McKay's avatar Steve McKay
Browse files

Include "remove supported" in debug view. 

It was omitted from the inspector.
Also alpha sorted accessors in DocumentInfo.

Test: passing.
Change-Id: I43893b6ed0607f57620e631e14af76fbf1ddddd1
parent 2bbdd651

res/values/inspector_strings.xml

+2 −0
Original line number Diff line number Diff line
@@ -110,6 +110,8 @@ 
    <string name="debug_supports_delete" translatable="false">Supports delete</string>

    <!-- String label for developer/debug file details, specifying that a file has associated metadata. -->

    <string name="debug_supports_metadata" translatable="false">Supports metadata</string>

    <!-- String label for developer/debug file details, specifying that a file can be removed. -->

    <string name="debug_supports_remove" translatable="false">Supports remove</string>

    <!-- String label for developer/debug file details, specifying that a file can be renamed. -->

    <string name="debug_supports_rename" translatable="false">Supports rename</string>

    <!-- String label for developer/debug file details, specifying that a file supports the "settings" feature. -->

src/com/android/documentsui/base/DocumentInfo.java

+16 −16
Original line number Diff line number Diff line
@@ -232,32 +232,28 @@ public class DocumentInfo implements Durable, Parcelable { 
        return (flags & Document.FLAG_DIR_SUPPORTS_CREATE) != 0;

    }



    public boolean isDirectory() {

        return Document.MIME_TYPE_DIR.equals(mimeType);

    }



    public boolean isWriteSupported() {

        return (flags & Document.FLAG_SUPPORTS_WRITE) != 0;

    }



    public boolean isDeleteSupported() {

        return (flags & Document.FLAG_SUPPORTS_DELETE) != 0;

    }



    public boolean isRemoveSupported() {

        return (flags & Document.FLAG_SUPPORTS_REMOVE) != 0;

    public boolean isMetadataSupported() {

        return (flags & Document.FLAG_SUPPORTS_METADATA) != 0;

    }



    public boolean isMoveSupported() {

        return (flags & Document.FLAG_SUPPORTS_MOVE) != 0;

    }



    public boolean isRemoveSupported() {

        return (flags & Document.FLAG_SUPPORTS_REMOVE) != 0;

    }



    public boolean isRenameSupported() {

        return (flags & Document.FLAG_SUPPORTS_RENAME) != 0;

    }



    public boolean isMetadataSupported() {

        return (flags & Document.FLAG_SUPPORTS_METADATA) != 0;

    public boolean isSettingsSupported() {

        return (flags & Document.FLAG_SUPPORTS_SETTINGS) != 0;

    }



    public boolean isThumbnailSupported() {
@@ -268,6 +264,14 @@ public class DocumentInfo implements Durable, Parcelable { 
        return (flags & Document.FLAG_WEB_LINKABLE) != 0;

    }



    public boolean isWriteSupported() {

        return (flags & Document.FLAG_SUPPORTS_WRITE) != 0;

    }



    public boolean isDirectory() {

        return Document.MIME_TYPE_DIR.equals(mimeType);

    }



    public boolean isArchive() {

        return ArchivesProvider.isSupportedArchiveType(mimeType);

    }
@@ -289,10 +293,6 @@ public class DocumentInfo implements Durable, Parcelable { 
        return (flags & Document.FLAG_VIRTUAL_DOCUMENT) != 0;

    }



    public boolean isSettingsSupported() {

        return (flags & Document.FLAG_SUPPORTS_SETTINGS) != 0;

    }



    public boolean prefersSortByLastModified() {

        return (flags & Document.FLAG_DIR_PREFERS_LAST_MODIFIED) != 0;

    }

src/com/android/documentsui/inspector/DebugView.java

+1 −0
Original line number Diff line number Diff line
@@ -84,6 +84,7 @@ public class DebugView extends TableView implements DebugDisplay { 
        put(R.string.debug_supports_create, info.isCreateSupported());

        put(R.string.debug_supports_delete, info.isDeleteSupported());

        put(R.string.debug_supports_metadata, info.isMetadataSupported());

        put(R.string.debug_supports_remove, info.isRemoveSupported());

        put(R.string.debug_supports_rename, info.isRenameSupported());

        put(R.string.debug_supports_settings, info.isSettingsSupported());

        put(R.string.debug_supports_thumbnail, info.isThumbnailSupported());