Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a299187d authored by Tony Huang's avatar Tony Huang
Browse files

Enlarge preview button touch area to meet GAR criteria 

GAR define view of touch area should at lease large than 48dp
We keep original icon size, but enlarge touch area.

Fix: 130207526
Test: manual use a11y scanner to check
Test: atest DocumentsUIGoogleTests
Change-Id: I3e59cd652e7ea7c227cd244f7da864f5e7c86535
parent 7aa96184

res/layout/item_doc_grid.xml

+4 −5
Original line number Diff line number Diff line
@@ -74,12 +74,10 @@ 


            <FrameLayout

                android:id="@+id/preview_icon"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_margin="4dp"

                android:layout_width="@dimen/button_touch_size"

                android:layout_height="@dimen/button_touch_size"

                android:layout_alignParentTop="true"

                android:layout_alignParentEnd="true"

                android:background="@drawable/circle_button_background"

                android:pointerIcon="hand"

                android:focusable="true"

                android:clickable="true">
@@ -87,8 +85,9 @@ 
                <ImageView

                    android:layout_width="@dimen/zoom_icon_size"

                    android:layout_height="@dimen/zoom_icon_size"

                    android:layout_margin="2dp"

                    android:padding="2dp"

                    android:layout_gravity="center"

                    android:background="@drawable/circle_button_background"

                    android:scaleType="fitCenter"

                    android:src="@drawable/ic_zoom_out"/>

res/layout/item_photo_grid.xml

+7 −12
Original line number Diff line number Diff line
@@ -64,15 +64,11 @@ 
        </FrameLayout>



        <FrameLayout

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_width="@dimen/button_touch_size"

            android:layout_height="@dimen/button_touch_size"

            android:layout_alignParentTop="true"

            android:layout_alignParentStart="true"

            android:pointerIcon="hand"

            android:paddingTop="2dp"

            android:paddingBottom="2dp"

            android:paddingStart="2dp"

            android:paddingEnd="2dp">

            android:pointerIcon="hand">



            <ImageView

                android:id="@+id/icon_check"
@@ -88,12 +84,10 @@ 


        <FrameLayout

            android:id="@+id/preview_icon"

            android:layout_width="wrap_content"

            android:layout_height="wrap_content"

            android:layout_margin="4dp"

            android:layout_width="@dimen/button_touch_size"

            android:layout_height="@dimen/button_touch_size"

            android:layout_alignParentTop="true"

            android:layout_alignParentEnd="true"

            android:background="@drawable/circle_button_background"

            android:pointerIcon="hand"

            android:focusable="true"

            android:clickable="true">
@@ -101,8 +95,9 @@ 
            <ImageView

                android:layout_width="@dimen/zoom_icon_size"

                android:layout_height="@dimen/zoom_icon_size"

                android:layout_margin="2dp"

                android:padding="2dp"

                android:layout_gravity="center"

                android:background="@drawable/circle_button_background"

                android:scaleType="fitCenter"

                android:src="@drawable/ic_zoom_out"/>

res/values/dimens.xml

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ 
    <dimen name="root_action_icon_size">18dp</dimen>

    <dimen name="root_icon_disabled_alpha">?android:attr/disabledAlpha</dimen>

    <dimen name="check_icon_size">30dp</dimen>

    <dimen name="zoom_icon_size">22dp</dimen>

    <dimen name="zoom_icon_size">24dp</dimen>

    <dimen name="list_item_thumbnail_size">40dp</dimen>

    <dimen name="grid_item_icon_size">30dp</dimen>

    <dimen name="progress_bar_height">4dp</dimen>