Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d3785d5 authored by François Degros's avatar François Degros
Browse files

Remove a null check 

Remove a null check in code that was recently added in ag/30576396.
This null check is not necessary anymore since the unit tests have been
updated.

Bug: 381002369
Flag: EXEMPT remove unnecessary check
Test: atest DocumentsUIGoogleTests:com.android.documentsui
Change-Id: I29d0f484988b99081084323711e938aab61b2662
parent 57088b37

src/com/android/documentsui/MenuManager.java

+1 −4
Original line number Diff line number Diff line
@@ -234,10 +234,7 @@ public abstract class MenuManager { 


        Menus.setEnabledAndVisible(inspect, selectionDetails.size() == 1);



        final MenuItem compress = menu.findItem(R.id.dir_menu_compress);

        if (compress != null) {

            updateCompress(compress, selectionDetails);

        }

        updateCompress(menu.findItem(R.id.dir_menu_compress), selectionDetails);

    }



    /**

src/com/android/documentsui/base/Menus.java

+3 −1
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ package com.android.documentsui.base; 
import android.view.Menu;

import android.view.MenuItem;



import androidx.annotation.NonNull;



public final class Menus {



    private Menus() {}
@@ -41,7 +43,7 @@ public final class Menus { 
    }



    /** Set enabled/disabled state of a menuItem, and updates its visibility. */

    public static void setEnabledAndVisible(MenuItem item, boolean enabled) {

    public static void setEnabledAndVisible(@NonNull MenuItem item, boolean enabled) {

        item.setEnabled(enabled);

        item.setVisible(enabled);

    }