Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98129c98 authored by Wenbo Jie's avatar Wenbo Jie
Browse files

[DocsUI M3] Update thumbnail border width to 1dp 

Check the attached bug for the before/after comparison.

Bug: 404256900
Test: m DocumentsUIGoogle && manual inspection
Flag: com.android.documentsui.flags.use_material3
Change-Id: I8471fc177230db3645ff68e502dbc5ef710f849c
parent 5d4b99a4

res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml

+1 −2
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
    <dimen name="button_touch_size">48dp</dimen>

    <dimen name="root_icon_size">24dp</dimen>

    <dimen name="thumbnail_clip_corner_radius">6dp</dimen>

    <dimen name="thumbnail_border_width">1dp</dimen>

    <!-- TODO(b/379776735): remove this block after use_material3 flag is launched. -->

    <dimen name="root_icon_margin">0dp</dimen>

    <dimen name="root_spacer_padding">0dp</dimen>
@@ -37,7 +38,6 @@ 
    <dimen name="check_icon_size">20dp</dimen>

    <dimen name="zoom_icon_size">24dp</dimen>

    <dimen name="list_item_thumbnail_size">40dp</dimen>

    <dimen name="list_item_thumbnail_border_width">2dp</dimen>

    <dimen name="grid_item_icon_size">30dp</dimen>

    <!-- TODO(b/379776735): remove this after use_material3 flag is launched. -->

    <dimen name="progress_bar_height">4dp</dimen>
@@ -77,7 +77,6 @@ 
    <dimen name="grid_item_thumbnail_width">80dp</dimen>

    <dimen name="grid_item_thumbnail_height">80dp</dimen>

    <dimen name="grid_item_thumbnail_radius">12dp</dimen>

    <dimen name="grid_item_thumbnail_border_width">2dp</dimen>

    <dimen name="grid_item_icon_width">64dp</dimen>

    <dimen name="grid_item_icon_height">64dp</dimen>

    <dimen name="grid_item_layout_margin">@dimen/space_small_1</dimen>

src/com/android/documentsui/dirlist/GridDocumentHolder.java

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ final class GridDocumentHolder extends DocumentHolder { 
            mIconCheck = null;

            mThumbnailStrokeWidth =

                    context.getResources()

                            .getDimensionPixelSize(R.dimen.grid_item_thumbnail_border_width);

                            .getDimensionPixelSize(R.dimen.thumbnail_border_width);

        } else {

            mBullet = null;

            mIconWrapper = null;

src/com/android/documentsui/dirlist/ListDocumentHolder.java

+1 −1
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ final class ListDocumentHolder extends DocumentHolder { 
        if (isUseMaterial3FlagEnabled()) {

            mThumbnailStrokeWidth =

                    context.getResources()

                            .getDimensionPixelSize(R.dimen.list_item_thumbnail_border_width);

                            .getDimensionPixelSize(R.dimen.thumbnail_border_width);

            int clipCornerRadius = context.getResources()

                    .getDimensionPixelSize(R.dimen.thumbnail_clip_corner_radius);

            IconUtils.applyThumbnailClipOutline(