Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97ce4ce5 authored by Tony Huang's avatar Tony Huang
Browse files

Fix crash issue when drag files 

It always crash when drag file on Recent root because its DocumentInfo
derivedUri is null.
Fix this by always generate dummy uri for this dummy DocumentInfo

Fix: 132755388
Test: manual
Test: atest DocumentsUIGoogleTests
Change-Id: Iee9fdb5eb83ac6dd6c45f575bcfe396f687a0ff9
parent 84d9de1a

src/com/android/documentsui/base/DocumentStack.java

+3 −1
Original line number Diff line number Diff line
@@ -162,7 +162,9 @@ public class DocumentStack implements Durable, Parcelable { 


        // Add this for keep stack size is 1 on recent root.

        if (root.isRecents()) {

            push(new DocumentInfo());

            DocumentInfo rootRecent = new DocumentInfo();

            rootRecent.deriveFields();

            push(rootRecent);

        }

    }

tests/unit/com/android/documentsui/base/DocumentStackTest.java

+2 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.documentsui.base; 


import static junit.framework.Assert.assertEquals;

import static junit.framework.Assert.assertFalse;

import static junit.framework.TestCase.assertNotNull;

import static junit.framework.TestCase.assertNull;

import static junit.framework.TestCase.assertTrue;
@@ -196,5 +197,6 @@ public class DocumentStackTest { 


        assertEquals(1, mStack.size());

        assertEquals(true, mStack.isRecents());

        assertNotNull(mStack.peek().derivedUri);

    }

}