Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84bd0f13 authored by Garfield Tan's avatar Garfield Tan
Browse files

Refactor SelectionModeListener. 

* Move ActionMode logic into a new class ActionModeController
* Move SelectionDetails logic into MultiSelectionController
* Merge canSelect() and onBeforeItemStateChange()
* Add some basic unit tests for selecting unselectable items
* Fix a bug that selects unselectable items using gestural selection
* Convert MultiSelectManagerTests to JUnit4

Change-Id: I14642178ff39e7b990cc9f3fb0d9f40e6309e087
parent ba7e6c4d

app-perf-tests/src/com/android/documentsui/LauncherActivity.java

+0 −2
Original line number Diff line number Diff line
@@ -20,10 +20,8 @@ import static com.android.documentsui.Shared.EXTRA_BENCHMARK; 


import android.app.Activity;

import android.content.Intent;

import android.content.pm.PackageManager;

import android.os.Bundle;

import android.os.Handler;

import android.util.Log;



import java.util.concurrent.CountDownLatch;

src/com/android/documentsui/Events.java

+0 −5
Original line number Diff line number Diff line
@@ -328,9 +328,4 @@ public final class Events { 
                    .toString();

        }

    }



    @FunctionalInterface

    public interface EventHandler {

        boolean apply(InputEvent event);

    }

}

src/com/android/documentsui/MenuManager.java

+0 −2
Original line number Diff line number Diff line
@@ -16,8 +16,6 @@ 


package com.android.documentsui;



import android.annotation.Nullable;

import android.support.v7.widget.RecyclerView;

import android.view.Menu;

import android.view.MenuItem;

src/com/android/documentsui/OpenExternalDirectoryActivity.java

+0 −2
Original line number Diff line number Diff line
@@ -17,12 +17,10 @@ 
package com.android.documentsui;



import static android.os.Environment.isStandardDirectory;

import static android.os.Environment.STANDARD_DIRECTORIES;

import static android.os.storage.StorageVolume.EXTRA_DIRECTORY_NAME;

import static android.os.storage.StorageVolume.EXTRA_STORAGE_VOLUME;



import static com.android.documentsui.LocalPreferences.getScopedAccessPermissionStatus;

import static com.android.documentsui.LocalPreferences.PERMISSION_ASK;

import static com.android.documentsui.LocalPreferences.PERMISSION_ASK_AGAIN;

import static com.android.documentsui.LocalPreferences.PERMISSION_NEVER_ASK;

import static com.android.documentsui.LocalPreferences.setScopedAccessPermissionStatus;

src/com/android/documentsui/QuickViewIntentBuilder.java

+0 −1
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ import static com.android.documentsui.model.DocumentInfo.getCursorString; 


import android.content.ClipData;

import android.content.ClipDescription;

import android.content.ComponentName;

import android.content.Intent;

import android.content.pm.PackageManager;

import android.content.res.Resources;